Fix compatibility with ROCm>=3.5.1; fix typo in hip neighbor_list#2012
Merged
wanghan-iapcm merged 18 commits intodeepmodeling:develfrom Oct 27, 2022
Merged
Fix compatibility with ROCm>=3.5.1; fix typo in hip neighbor_list#2012wanghan-iapcm merged 18 commits intodeepmodeling:develfrom
wanghan-iapcm merged 18 commits intodeepmodeling:develfrom
Conversation
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Member
Author
|
For a CI environment, I am waiting for ROCm/ROCm#1713 to be resolved... |
This was
linked to
issues
Oct 19, 2022
Codecov ReportBase: 73.58% // Head: 73.85% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## devel #2012 +/- ##
==========================================
+ Coverage 73.58% 73.85% +0.26%
==========================================
Files 198 198
Lines 19908 19908
Branches 854 865 +11
==========================================
+ Hits 14650 14703 +53
+ Misses 4870 4813 -57
- Partials 388 392 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Member
Author
|
@galeselee please help review this PR. |
galeselee
reviewed
Oct 19, 2022
Contributor
|
In addition, the previous rocm-4 has the problem that the community user feedback calculation results are not correct, but UT can pass. |
Contributor
|
LGTM |
galeselee
approved these changes
Oct 19, 2022
wanghan-iapcm
approved these changes
Oct 20, 2022
iProzd
approved these changes
Oct 20, 2022
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
add unit tests for rocm
wanghan-iapcm
approved these changes
Oct 27, 2022
mingzhong15
pushed a commit
to mingzhong15/deepmd-kit
that referenced
this pull request
Jan 15, 2023
…epmodeling#2012) Fixes deepmodeling#1400. Fixes deepmodeling#2009. 1. Uses cmake native module `CMakeDetermineHIPCompiler` to find the search path; 2. for ROCm>=3.5.1, `hip-hcc hiprtc` is replaced by `amd_comgr amdhip64`, per ROCm/ROCm#1200. (I am not sure about the situation of `amd_comgr`?) 3. Removes `-hc` from the flag for ROCm>=3.5.1. 4. Bumps from C++11 to C++14 as C++ 14 required by `amd_comgr`. 5. Removes `--amdgpu-target=gfx906`. I don't see the reason why it is in the flag. 6. Fixes a typo in deepmodeling#1866. Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1400. Fixes #2009.
CMakeDetermineHIPCompilerto find the search path;hip-hcc hiprtcis replaced byamd_comgr amdhip64, per ROCm 3.7 installation missing libraries for Tensorflow-rocm ROCm/ROCm#1200. (I am not sure about the situation ofamd_comgr?)-hcfrom the flag for ROCm>=3.5.1.amd_comgr.--amdgpu-target=gfx906. I don't see the reason why it is in the flag.