cmake: set TensorFlow as import libraries#2056
Merged
wanghan-iapcm merged 6 commits intodeepmodeling:develfrom Nov 4, 2022
Merged
cmake: set TensorFlow as import libraries#2056wanghan-iapcm merged 6 commits intodeepmodeling:develfrom
wanghan-iapcm merged 6 commits intodeepmodeling:develfrom
Conversation
Sets TensorFlow as import libraries (TensorFlow::tensorflow_framework, TensorFlow::tensorflow_cc), so we can just use target_link_libraries without target_include_directories. Also changes the TF scope in api_cc from PUBLIC to PRIVATE, and removes TF requirements from lmp and gmx. It was required, but not required any more after deepmodeling#1789 merged.
Codecov ReportBase: 73.79% // Head: 73.79% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## devel #2056 +/- ##
=======================================
Coverage 73.79% 73.79%
=======================================
Files 199 199
Lines 19957 19957
Branches 864 864
=======================================
Hits 14728 14728
Misses 4837 4837
Partials 392 392 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
wanghan-iapcm
approved these changes
Nov 4, 2022
mingzhong15
pushed a commit
to mingzhong15/deepmd-kit
that referenced
this pull request
Jan 15, 2023
Sets TensorFlow as import libraries (TensorFlow::tensorflow_framework, TensorFlow::tensorflow_cc), so we can just use target_link_libraries without target_include_directories. Also changes the TF scope in api_cc from PUBLIC to PRIVATE, and removes TF requirements from lmp and gmx. It was required, but not required any more after deepmodeling#1789 merged. Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets TensorFlow as import libraries (TensorFlow::tensorflow_framework, TensorFlow::tensorflow_cc), so we can just use target_link_libraries without target_include_directories.
Also changes the TF scope in api_cc from PUBLIC to PRIVATE, and removes TF requirements from lmp and gmx. It was required, but not required any more after #1789 merged.