clean deprecated codes#2140
Merged
wanghan-iapcm merged 6 commits intodeepmodeling:develfrom Nov 29, 2022
Merged
Conversation
Remove lots of decpreated codes, including: 1. ClassArg, and all related codes; 2. WFCFitting, PolarFittingLocFrame, which were marked deprecated; 3. Loss.print_header, Loss.print_on_training, which were marked deprecated; 4. DataSets and DataSystem, which were marked deprecated; 5. source/op/legacy There is no reason to keep them. Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Codecov ReportBase: 73.78% // Head: 74.11% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## devel #2140 +/- ##
==========================================
+ Coverage 73.78% 74.11% +0.33%
==========================================
Files 202 201 -1
Lines 20370 19760 -610
Branches 1416 1416
==========================================
- Hits 15030 14646 -384
+ Misses 4402 4175 -227
- Partials 938 939 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
wanghan-iapcm
approved these changes
Nov 29, 2022
mingzhong15
pushed a commit
to mingzhong15/deepmd-kit
that referenced
this pull request
Jan 15, 2023
Remove lots of deprecated codes, including: 1. `ClassArg`, and all related codes; 2. `WFCFitting`, `PolarFittingLocFrame`, which were marked deprecated; 3. `Loss.print_header`, `Loss.print_on_training`, which were marked deprecated; 4. `DataSets` and `DataSystem`, which were marked deprecated; 5. `source/op/legacy`. There is no reason to keep them. `DataSystem` and `DataSystem` are moved to tests as some tests still need it. Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove lots of deprecated codes, including:
ClassArg, and all related codes;WFCFitting,PolarFittingLocFrame, which were marked deprecated;Loss.print_header,Loss.print_on_training, which were marked deprecated;DataSetsandDataSystem, which were marked deprecated;source/op/legacy.There is no reason to keep them.
DataSystemandDataSystemare moved to tests as some tests still need it.