retag wheels to py37-none-<platform>#2180
Merged
wanghan-iapcm merged 4 commits intodeepmodeling:develfrom Dec 15, 2022
Merged
Conversation
The binary in our wheels do not link Python libraries, so we can create universal wheels.
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
njzjz
changed the title
py37-none-<platform>py37-none-<platform>
wanghan-iapcm
approved these changes
Dec 15, 2022
wanghan-iapcm
pushed a commit
that referenced
this pull request
Dec 17, 2022
With #2180, now it only has 4 tasks to build wheels. But this task is still so slow.. Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
njzjz
added a commit
to njzjz/deepmd-kit
that referenced
this pull request
Dec 18, 2022
With deepmodeling#2180, now it only has 4 tasks to build wheels. But this task is still so slow.. Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
mingzhong15
pushed a commit
to mingzhong15/deepmd-kit
that referenced
this pull request
Jan 15, 2023
Our wheels do not link against any Python ABIs. The libraries only link against TensorFlow ABIs. So it's safe to retag them to `py37-none-<platform>` but keep the platform tag. We only need to build the wheel once for a platform to reduce the CI time, and the wheel should work for all Python versions. References: [PEP 425](https://peps.python.org/pep-0425/) Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
mingzhong15
pushed a commit
to mingzhong15/deepmd-kit
that referenced
this pull request
Jan 15, 2023
With deepmodeling#2180, now it only has 4 tasks to build wheels. But this task is still so slow.. Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our wheels do not link against any Python ABIs. The libraries only link against TensorFlow ABIs. So it's safe to retag them to
py37-none-<platform>but keep the platform tag. We only need to build the wheel once for a platform to reduce the CI time, and the wheel should work for all Python versions.References: PEP 425