Skip to content

Change gridcomm into grid3d in pppm_dplr.cpp to support LAMMPS after 20221222#2300

Merged
wanghan-iapcm merged 16 commits intodeepmodeling:develfrom
Yi-FanLi:lmp20221222
Feb 6, 2023
Merged

Change gridcomm into grid3d in pppm_dplr.cpp to support LAMMPS after 20221222#2300
wanghan-iapcm merged 16 commits intodeepmodeling:develfrom
Yi-FanLi:lmp20221222

Conversation

@Yi-FanLi
Copy link
Collaborator

@Yi-FanLi Yi-FanLi commented Feb 4, 2023

Fix #2275

@github-actions github-actions bot added the LAMMPS label Feb 4, 2023
@Yi-FanLi Yi-FanLi requested a review from njzjz February 4, 2023 23:27
@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2023

Codecov Report

Base: 74.88% // Head: 74.85% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (a879a18) compared to base (97c38bb).
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #2300      +/-   ##
==========================================
- Coverage   74.88%   74.85%   -0.04%     
==========================================
  Files         217      217              
  Lines       21560    21560              
  Branches     1577     1577              
==========================================
- Hits        16145    16138       -7     
- Misses       4397     4407      +10     
+ Partials     1018     1015       -3     
Impacted Files Coverage Δ
source/lmp/pppm_dplr.cpp 0.00% <ø> (ø)
source/op/matmul_flt2fix_nvnmd.cc 84.12% <0.00%> (-1.59%) ⬇️
source/lmp/pair_deepmd.cpp 47.21% <0.00%> (-0.91%) ⬇️
source/lib/include/ComputeDescriptor.h 79.13% <0.00%> (+0.18%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wanghan-iapcm wanghan-iapcm merged commit 18f80b7 into deepmodeling:devel Feb 6, 2023
@Gengzhenchao
Copy link

image
Hello, may I ask if there is such an error on the picture, how should I solve it?

@njzjz
Copy link
Member

njzjz commented Apr 18, 2023

Hello, may I ask if there is such an error on the picture, how should I solve it?

Patch #2417

@Gengzhenchao
Copy link

Hello, may I ask if there is such an error on the picture, how should I solve it?

Patch #2417

Thank you very much for your answer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Modify dplr source code to support the newest LAMMPS

5 participants