Merged
Conversation
…mode at LAMMPS version >= 20210831.
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
njzjz
previously approved these changes
Apr 1, 2023
Member
njzjz
left a comment
njzjz
left a comment
There was a problem hiding this comment.
Approve, although I hope a test
Collaborator
Author
|
I added a test. However, I am not able to set up the pytest environment on my local computer right now. I pushed the test to this branch, and let's see how github actions perform on this test. |
Member
|
I add |
select_real_atoms for model deviation
wanghan-iapcm
requested changes
Apr 3, 2023
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
wanghan-iapcm
approved these changes
Apr 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DPLR is broken due to the change of coeff(int narg, char **arg) function. The current coeff function requires that the number of types in LAMMPS no more than that in model. In dplr, however, there might be more types in LAMMPS than in the model. This check should be bypassed.