Skip to content

improve docs and scripts to install libtensorflow_cc 2.12#2571

Merged
wanghan-iapcm merged 2 commits intodeepmodeling:develfrom
njzjz:build-tf-2.12
May 25, 2023
Merged

improve docs and scripts to install libtensorflow_cc 2.12#2571
wanghan-iapcm merged 2 commits intodeepmodeling:develfrom
njzjz:build-tf-2.12

Conversation

@njzjz
Copy link
Member

@njzjz njzjz commented May 25, 2023

In TF 2.11, TensorFlow adds a new directory, "tensorflow/tsl" where the headers should be copied.

  1. add docs to install TF 2.12;
  2. build_tf.py: bump to TF 2.12, and copy tensorflow/tsl;
  3. output the detailed errors when checking ABIs. Sometimes the reason is missing header files instead of ABI.

In TF 2.11, TensorFlow adds a new directory "tensorflow/tsl" where the headers should be copied.

1. add docs to install TF 2.12
2. build_tf.py: bump to TF 2.12, and copy tensorflow/tsl
3. output the detailed errors when checking ABIs. Sometimes the reason is missing header files instead of ABI.

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@github-actions github-actions bot added the Docs label May 25, 2023
@njzjz njzjz changed the title improve docs and scripts to install TF 2.12 improve docs and scripts to install libtensorflow_cc 2.12 May 25, 2023
@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (5f5248c) 76.82% compared to head (909e23d) 76.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #2571      +/-   ##
==========================================
- Coverage   76.82%   76.82%   -0.01%     
==========================================
  Files         227      227              
  Lines       23805    23805              
  Branches     1653     1667      +14     
==========================================
- Hits        18289    18287       -2     
  Misses       4422     4422              
- Partials     1094     1096       +2     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wanghan-iapcm wanghan-iapcm enabled auto-merge (squash) May 25, 2023 23:10
@wanghan-iapcm wanghan-iapcm merged commit a0815b9 into deepmodeling:devel May 25, 2023
nahso pushed a commit to HPC-AI-Team/deepmd-kit-se_atten-models that referenced this pull request May 29, 2023
…ng#2571)

In TF 2.11, TensorFlow adds a new directory, "tensorflow/tsl" where the
headers should be copied.

1. add docs to install TF 2.12;
2. build_tf.py: bump to TF 2.12, and copy `tensorflow/tsl`;
3. output the detailed errors when checking ABIs. Sometimes the reason
is missing header files instead of ABI.

---------

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants