breaking: add energy bias to tab potential#2670
Merged
wanghan-iapcm merged 4 commits intodeepmodeling:develfrom Jul 20, 2023
Merged
breaking: add energy bias to tab potential#2670wanghan-iapcm merged 4 commits intodeepmodeling:develfrom
wanghan-iapcm merged 4 commits intodeepmodeling:develfrom
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## devel #2670 +/- ##
==========================================
- Coverage 78.36% 78.17% -0.19%
==========================================
Files 235 238 +3
Lines 24488 24859 +371
Branches 1469 1509 +40
==========================================
+ Hits 19189 19434 +245
- Misses 4909 5035 +126
Partials 390 390
☔ View full report in Codecov by Sentry. |
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Member
Author
|
@wanghan-iapcm any comments on this PR? Maybe we can discuss it outside the GitHub. |
Collaborator
Sure ! |
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
wanghan-iapcm
approved these changes
Jul 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #2662.
Forces and virials will be changed accordingly.
One can turn off the new behavior by setting
srtab_add_biasto False.