breaking: change the default value of rcond from 1e-3 to None#2688
Merged
wanghan-iapcm merged 3 commits intodeepmodeling:develfrom Jul 20, 2023
Merged
breaking: change the default value of rcond from 1e-3 to None#2688wanghan-iapcm merged 3 commits intodeepmodeling:develfrom
rcond from 1e-3 to None#2688wanghan-iapcm merged 3 commits intodeepmodeling:develfrom
Conversation
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
for more information, see https://pre-commit.ci
njzjz
added a commit
to dptech-corp/deepmd-pytorch
that referenced
this pull request
Jul 19, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## devel #2688 +/- ##
==========================================
+ Coverage 78.36% 78.37% +0.01%
==========================================
Files 235 235
Lines 24506 24506
Branches 1469 1469
==========================================
+ Hits 19204 19207 +3
+ Misses 4910 4907 -3
Partials 392 392
☔ View full report in Codecov by Sentry. |
iProzd
approved these changes
Jul 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a breaking change.
rcond=1e-3is found inaccurate. Using NumPy's default value is more accurate and not too slow.