set cmake_minimum_required for CUDA/ROCm#2695
Merged
wanghan-iapcm merged 1 commit intodeepmodeling:develfrom Jul 26, 2023
Merged
set cmake_minimum_required for CUDA/ROCm#2695wanghan-iapcm merged 1 commit intodeepmodeling:develfrom
wanghan-iapcm merged 1 commit intodeepmodeling:develfrom
Conversation
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## devel #2695 +/- ##
==========================================
- Coverage 78.72% 78.71% -0.01%
==========================================
Files 239 239
Lines 25549 25549
Branches 1517 1517
==========================================
- Hits 20114 20112 -2
Misses 5045 5045
- Partials 390 392 +2 ☔ View full report in Codecov by Sentry. |
nahso
approved these changes
Jul 26, 2023
wanghan-iapcm
approved these changes
Jul 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although we have set it in
source/lib/src/cuda/CMakeLists.txt, the mainCMakeLists.txtneeds it.