fix bug in deepmd.infer.deep_pot.DeepPot#2731
Merged
wanghan-iapcm merged 4 commits intodeepmodeling:develfrom Aug 19, 2023
ChiahsinChu:devel
Merged
fix bug in deepmd.infer.deep_pot.DeepPot#2731wanghan-iapcm merged 4 commits intodeepmodeling:develfrom ChiahsinChu:devel
wanghan-iapcm merged 4 commits intodeepmodeling:develfrom
ChiahsinChu:devel
Conversation
- fix bug in checking t_efield op in the graph - delete arg atomic in `_prepare_feed_dict` (otherwise, efield cannot be imported correctly when using this method)
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## devel #2731 +/- ##
==========================================
- Coverage 78.73% 78.73% -0.01%
==========================================
Files 241 241
Lines 25582 25582
Branches 1517 1517
==========================================
- Hits 20143 20141 -2
Misses 5049 5049
- Partials 390 392 +2
☔ View full report in Codecov by Sentry. |
njzjz
requested changes
Aug 9, 2023
for more information, see https://pre-commit.ci
wanghan-iapcm
approved these changes
Aug 10, 2023
njzjz
approved these changes
Aug 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_prepare_feed_dict(otherwise, efield cannot be imported correctly when using this method)