Skip to content

fix bug in deepmd.infer.deep_pot.DeepPot#2731

Merged
wanghan-iapcm merged 4 commits intodeepmodeling:develfrom
ChiahsinChu:devel
Aug 19, 2023
Merged

fix bug in deepmd.infer.deep_pot.DeepPot#2731
wanghan-iapcm merged 4 commits intodeepmodeling:develfrom
ChiahsinChu:devel

Conversation

@ChiahsinChu
Copy link
Contributor

  • fix bug in checking t_efield op in the graph
  • delete arg atomic in _prepare_feed_dict (otherwise, efield cannot be imported correctly when using this method)

- fix bug in checking t_efield op in the graph
- delete arg atomic in `_prepare_feed_dict` (otherwise, efield cannot be imported correctly when using this method)
@github-actions github-actions bot added the Python label Aug 9, 2023
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Patch coverage: 80.00% and project coverage change: -0.01% ⚠️

Comparison is base (54cb07b) 78.73% compared to head (1d54576) 78.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #2731      +/-   ##
==========================================
- Coverage   78.73%   78.73%   -0.01%     
==========================================
  Files         241      241              
  Lines       25582    25582              
  Branches     1517     1517              
==========================================
- Hits        20143    20141       -2     
  Misses       5049     5049              
- Partials      390      392       +2     
Files Changed Coverage Δ
deepmd/infer/deep_pot.py 82.88% <80.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@njzjz njzjz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

os.path.join has different behaviors on Windows. / is preferred.

@wanghan-iapcm wanghan-iapcm requested a review from njzjz August 10, 2023 02:09
@wanghan-iapcm wanghan-iapcm merged commit 5f8c976 into deepmodeling:devel Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants