lmp: add unit_style requirement for compute deeptensor/atom#2790
Merged
wanghan-iapcm merged 2 commits intodeepmodeling:develfrom Sep 6, 2023
Merged
Conversation
The input of the model should be Angstron so that the unit style can only be metal or real. Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
for more information, see https://pre-commit.ci
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## devel #2790 +/- ##
==========================================
- Coverage 78.66% 78.65% -0.01%
==========================================
Files 244 244
Lines 25813 25815 +2
Branches 1519 1519
==========================================
Hits 20305 20305
- Misses 5115 5117 +2
Partials 393 393
☔ View full report in Codecov by Sentry. |
wanghan-iapcm
approved these changes
Sep 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The input of the model should be Angstron so that the unit style can only be metal or real.