migrate Python build backend to scikit-build-core#2798
Merged
wanghan-iapcm merged 12 commits intodeepmodeling:develfrom Sep 11, 2023
Merged
migrate Python build backend to scikit-build-core#2798wanghan-iapcm merged 12 commits intodeepmodeling:develfrom
wanghan-iapcm merged 12 commits intodeepmodeling:develfrom
Conversation
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## devel #2798 +/- ##
=======================================
Coverage 79.37% 79.37%
=======================================
Files 244 244
Lines 25820 25875 +55
Branches 1519 1533 +14
=======================================
+ Hits 20494 20538 +44
- Misses 4933 4938 +5
- Partials 393 399 +6
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here. |
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
wanghan-iapcm
approved these changes
Sep 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates the Python build backend from scikit-build to scikit-build-core, which is being actively developed.
There are no breaking changes to users; all tests should be passed without modification.
The behavior for editable installation (
pip install -e .) is changed. Before, the compiled binary libraries (e.g.libdeepmd_op.sp) are installed into the source directory. In this PR, the library files are installed intosite-packagesseparately, while the Python files are still in the source code and can be modified for development.