Skip to content

migrate Python build backend to scikit-build-core#2798

Merged
wanghan-iapcm merged 12 commits intodeepmodeling:develfrom
njzjz:scikit-build-core
Sep 11, 2023
Merged

migrate Python build backend to scikit-build-core#2798
wanghan-iapcm merged 12 commits intodeepmodeling:develfrom
njzjz:scikit-build-core

Conversation

@njzjz
Copy link
Member

@njzjz njzjz commented Sep 8, 2023

This PR migrates the Python build backend from scikit-build to scikit-build-core, which is being actively developed.

There are no breaking changes to users; all tests should be passed without modification.

The behavior for editable installation (pip install -e .) is changed. Before, the compiled binary libraries (e.g. libdeepmd_op.sp) are installed into the source directory. In this PR, the library files are installed into site-packages separately, while the Python files are still in the source code and can be modified for development.

njzjz added 10 commits September 6, 2023 05:17
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch coverage: 93.75% and no project coverage change.

Comparison is base (9712c13) 79.37% compared to head (6c41026) 79.37%.
Report is 3 commits behind head on devel.

Additional details and impacted files
@@           Coverage Diff           @@
##            devel    #2798   +/-   ##
=======================================
  Coverage   79.37%   79.37%           
=======================================
  Files         244      244           
  Lines       25820    25875   +55     
  Branches     1519     1533   +14     
=======================================
+ Hits        20494    20538   +44     
- Misses       4933     4938    +5     
- Partials      393      399    +6     
Files Changed Coverage Δ
deepmd/lmp.py 0.00% <0.00%> (ø)
deepmd/op/_add_flt_nvnmd_grad.py 57.14% <ø> (ø)
deepmd/op/_copy_flt_nvnmd_grad.py 100.00% <ø> (ø)
deepmd/op/_dotmul_flt_nvnmd_grad.py 26.66% <ø> (ø)
deepmd/op/_flt_nvnmd_grad.py 100.00% <ø> (ø)
deepmd/op/_gelu.py 68.42% <ø> (ø)
deepmd/op/_map_flt_nvnmd_grad.py 100.00% <ø> (ø)
deepmd/op/_matmul_fitnet_nvnmd_grad.py 100.00% <ø> (ø)
deepmd/op/_matmul_flt2fix_nvnmd.py 90.00% <ø> (ø)
deepmd/op/_matmul_flt_nvnmd_grad.py 85.71% <ø> (ø)
... and 15 more

... and 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz njzjz requested a review from wanghan-iapcm September 8, 2023 06:24
@wanghan-iapcm wanghan-iapcm merged commit 6e306fa into deepmodeling:devel Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants