lmp: let fparam_do_compute not execute by default#2819
Merged
wanghan-iapcm merged 1 commit intodeepmodeling:develfrom Sep 15, 2023
Merged
lmp: let fparam_do_compute not execute by default#2819wanghan-iapcm merged 1 commit intodeepmodeling:develfrom
wanghan-iapcm merged 1 commit intodeepmodeling:develfrom
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## devel #2819 +/- ##
==========================================
- Coverage 75.52% 75.49% -0.04%
==========================================
Files 242 242
Lines 24162 24163 +1
Branches 1533 1533
==========================================
- Hits 18249 18241 -8
- Misses 4997 5006 +9
Partials 916 916
☔ View full report in Codecov by Sentry. |
njzjz
approved these changes
Sep 14, 2023
wanghan-iapcm
approved these changes
Sep 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One should set the variable do_compute in pair_deepmd.cpp false by default, so that fparam can be used correctly. The current version will trigger the error
deepmd-kit/source/lmp/pair_deepmd.cpp
Lines 1044 to 1046 in 7da9aaf