Skip to content

Update Data.py#290

Merged
amcadmus merged 2 commits intodeepmodeling:masterfrom
bwang-ecnu:test-pr
Nov 15, 2020
Merged

Update Data.py#290
amcadmus merged 2 commits intodeepmodeling:masterfrom
bwang-ecnu:test-pr

Conversation

@bwang-ecnu
Copy link
Contributor

When condition “if coeff_atom_ener==1:” is established and one would like to ignore the energy_file, it seems to need to replace "coeff_atom_ener=1" with "coeff_ener=0".

When condition “if coeff_atom_ener==1:” is established and one would like to ignore the energy_file, it seems to need to replace "coeff_atom_ener=1" with "coeff_ener=0".
@njzjz njzjz requested a review from amcadmus November 9, 2020 13:53
Copy link
Member

@amcadmus amcadmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be coeff_ener = 1?
at line 478 the system energy is computed by reducing the atomic energies. thus we have the system energy label.

@amcadmus amcadmus merged commit b64dbcf into deepmodeling:master Nov 15, 2020
@njzjz
Copy link
Member

njzjz commented Nov 17, 2020

This PR was merged into master...

gzq942560379 pushed a commit to HPC-AI-Team/deepmd-kit that referenced this pull request Sep 1, 2021
njzjz pushed a commit to njzjz/deepmd-kit that referenced this pull request Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants