Merged
Conversation
When condition “if coeff_atom_ener==1:” is established and one would like to ignore the energy_file, it seems to need to replace "coeff_atom_ener=1" with "coeff_ener=0".
njzjz
approved these changes
Nov 9, 2020
amcadmus
requested changes
Nov 13, 2020
Member
amcadmus
left a comment
There was a problem hiding this comment.
Shouldn't it be coeff_ener = 1?
at line 478 the system energy is computed by reducing the atomic energies. thus we have the system energy label.
amcadmus
approved these changes
Nov 13, 2020
Member
|
This PR was merged into master... |
gzq942560379
pushed a commit
to HPC-AI-Team/deepmd-kit
that referenced
this pull request
Sep 1, 2021
Update Data.py
njzjz
pushed a commit
to njzjz/deepmd-kit
that referenced
this pull request
Sep 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When condition “if coeff_atom_ener==1:” is established and one would like to ignore the energy_file, it seems to need to replace "coeff_atom_ener=1" with "coeff_ener=0".