Skip to content

CI: bump CUDA image to 12.9.1#5107

Merged
njzjz merged 2 commits intodeepmodeling:develfrom
njzjz:bump-cuda-to-12-9
Dec 19, 2025
Merged

CI: bump CUDA image to 12.9.1#5107
njzjz merged 2 commits intodeepmodeling:develfrom
njzjz:bump-cuda-to-12-9

Conversation

@njzjz
Copy link
Member

@njzjz njzjz commented Dec 18, 2025

Summary by CodeRabbit

  • Chores
    • Updated CUDA testing environment to a newer runtime version for improved compatibility and stability.
    • Added installation of the NVIDIA cuBLAS package in CUDA tests to ensure required GPU math libraries are available.

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@ustc.edu.cn>
Copilot AI review requested due to automatic review settings December 18, 2025 14:48
@njzjz njzjz enabled auto-merge December 18, 2025 14:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the CUDA container image version used in the CI workflow from 12.6.2 to 12.9.1, keeping the workflow current with newer CUDA releases.

  • Updated NVIDIA CUDA Docker image from version 12.6.2 to 12.9.1

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 18, 2025

📝 Walkthrough

Walkthrough

Updated the GitHub Actions CUDA test workflow: bumped the nvidia/cuda container image from 12.6.2-cudnn-devel-ubuntu22.04 to 12.9.1-cudnn-devel-ubuntu22.04 and added a step to install nvidia-cublas-cu12>=12.9.0.13 via the existing UV retry installer. No other workflow logic changed.

Changes

Cohort / File(s) Change Summary
CUDA CI Configuration
/.github/workflows/test_cuda.yml
Bumped container image from nvidia/cuda:12.6.2-cudnn-devel-ubuntu22.04 to nvidia/cuda:12.9.1-cudnn-devel-ubuntu22.04; added a step to install nvidia-cublas-cu12>=12.9.0.13 using uv_with_retry.sh.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Pay attention to the added package installation step and its retry wrapper for compatibility with the updated CUDA image.

Possibly related PRs

  • ci: install GPU JAX in GPU CI #4293: Modifies the same CI workflow (.github/workflows/test_cuda.yml) to change GPU-related install steps and environment variables (related changes to CUDA test environment).

Suggested labels

CUDA

Suggested reviewers

  • wanghan-iapcm

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'CI: bump CUDA image to 12.9.1' directly and clearly describes the main change—updating the CUDA container image version in the CI workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1fecb54 and 84328bb.

📒 Files selected for processing (1)
  • .github/workflows/test_cuda.yml (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/test_cuda.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (28)
  • GitHub Check: Test Python (4, 3.13)
  • GitHub Check: Test Python (6, 3.10)
  • GitHub Check: Test Python (2, 3.10)
  • GitHub Check: Test Python (4, 3.10)
  • GitHub Check: Test Python (2, 3.13)
  • GitHub Check: Test Python (6, 3.13)
  • GitHub Check: Test Python (5, 3.13)
  • GitHub Check: Test Python (5, 3.10)
  • GitHub Check: Test Python (1, 3.13)
  • GitHub Check: Test Python (3, 3.10)
  • GitHub Check: Test Python (1, 3.10)
  • GitHub Check: Test Python (3, 3.13)
  • GitHub Check: Build C++ (cpu, cpu)
  • GitHub Check: Build C++ (rocm, rocm)
  • GitHub Check: Build C++ (clang, clang)
  • GitHub Check: Build C++ (cuda120, cuda)
  • GitHub Check: Analyze (python)
  • GitHub Check: Analyze (c-cpp)
  • GitHub Check: Build wheels for cp310-manylinux_aarch64
  • GitHub Check: Build C library (2.18, libdeepmd_c.tar.gz)
  • GitHub Check: Build wheels for cp311-macosx_x86_64
  • GitHub Check: Test C++ (true, false, false, true)
  • GitHub Check: Test C++ (false, false, false, true)
  • GitHub Check: Test C++ (false, true, true, false)
  • GitHub Check: Test C++ (true, true, true, false)
  • GitHub Check: Build wheels for cp311-macosx_arm64
  • GitHub Check: Build wheels for cp311-manylinux_x86_64
  • GitHub Check: Build wheels for cp311-win_amd64

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
.github/workflows/test_cuda.yml (1)

50-50: Update PaddlePaddle to cu129 wheels for CUDA 12.9.1.

PaddlePaddle provides nightly wheels for CUDA 12.9 via the cu129 repository, while line 50 currently uses cu126 wheels (CUDA 12.6). The cu126 variant is compatible with LibCUDA 12.0 and above, but cu129 is recommended for CUDA 12.9. To ensure optimal compatibility with the CUDA 12.9.1 runtime, change the index URL from cu126 to cu129 or confirm that cu126 wheels will not cause runtime issues in this environment.

📜 Review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 26013cb and 1fecb54.

📒 Files selected for processing (1)
  • .github/workflows/test_cuda.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (29)
  • GitHub Check: Upload results
  • GitHub Check: Test Python (6, 3.10)
  • GitHub Check: Test Python (5, 3.10)
  • GitHub Check: Test Python (4, 3.10)
  • GitHub Check: Test Python (5, 3.13)
  • GitHub Check: Test Python (6, 3.13)
  • GitHub Check: Test Python (4, 3.13)
  • GitHub Check: Test Python (1, 3.10)
  • GitHub Check: Test Python (3, 3.13)
  • GitHub Check: Test Python (3, 3.10)
  • GitHub Check: Test Python (2, 3.13)
  • GitHub Check: Test Python (2, 3.10)
  • GitHub Check: Test Python (1, 3.13)
  • GitHub Check: Build wheels for cp311-manylinux_x86_64
  • GitHub Check: Build wheels for cp310-manylinux_aarch64
  • GitHub Check: Build wheels for cp311-win_amd64
  • GitHub Check: Build wheels for cp311-macosx_x86_64
  • GitHub Check: Build wheels for cp311-macosx_arm64
  • GitHub Check: Build C++ (cpu, cpu)
  • GitHub Check: Build C++ (cuda120, cuda)
  • GitHub Check: Build C++ (rocm, rocm)
  • GitHub Check: Test C++ (false, false, false, true)
  • GitHub Check: Build C++ (clang, clang)
  • GitHub Check: Test C++ (false, true, true, false)
  • GitHub Check: Test C++ (true, true, true, false)
  • GitHub Check: Test C++ (true, false, false, true)
  • GitHub Check: Build C library (2.18, libdeepmd_c.tar.gz)
  • GitHub Check: Analyze (python)
  • GitHub Check: Analyze (c-cpp)
🔇 Additional comments (1)
.github/workflows/test_cuda.yml (1)

22-22: Container image version update looks good.

The CUDA image bump from 12.6.2 to 12.9.1 maintains the same base configuration (nvidia/cuda with cudnn on ubuntu22.04), and most downstream steps use generic cu12 tags that are compatible across CUDA 12.x versions.

@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.14%. Comparing base (d774ede) to head (84328bb).
⚠️ Report is 14 commits behind head on devel.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #5107      +/-   ##
==========================================
+ Coverage   82.12%   82.14%   +0.02%     
==========================================
  Files         709      709              
  Lines       72508    72458      -50     
  Branches     3616     3616              
==========================================
- Hits        59545    59520      -25     
+ Misses      11801    11776      -25     
  Partials     1162     1162              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@njzjz njzjz added this pull request to the merge queue Dec 18, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 18, 2025
@njzjz njzjz added this pull request to the merge queue Dec 18, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 18, 2025
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@ustc.edu.cn>
@njzjz njzjz enabled auto-merge December 19, 2025 10:24
@njzjz njzjz added this pull request to the merge queue Dec 19, 2025
Merged via the queue into deepmodeling:devel with commit 4c8880c Dec 19, 2025
58 checks passed
@njzjz njzjz deleted the bump-cuda-to-12-9 branch December 19, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants