Skip to content

seperate impl of averging errors across systems#518

Merged
amcadmus merged 3 commits intodeepmodeling:develfrom
amcadmus:devel
Apr 16, 2021
Merged

seperate impl of averging errors across systems#518
amcadmus merged 3 commits intodeepmodeling:develfrom
amcadmus:devel

Conversation

@amcadmus
Copy link
Member

No description provided.

@amcadmus amcadmus requested a review from ZiyaoLi April 16, 2021 04:33
Copy link
Member

@ZiyaoLi ZiyaoLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better to switch 'l2' to 'rmse' for unity?

@amcadmus
Copy link
Member Author

Would it be better to switch 'l2' to 'rmse' for unity?

Sure we should use rmse

@codecov-io
Copy link

codecov-io commented Apr 16, 2021

Codecov Report

Merging #518 (2186788) into devel (c667d00) will increase coverage by 0.05%.
The diff coverage is 12.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel     #518      +/-   ##
==========================================
+ Coverage   59.59%   59.65%   +0.05%     
==========================================
  Files          73       74       +1     
  Lines        6178     6177       -1     
==========================================
+ Hits         3682     3685       +3     
+ Misses       2496     2492       -4     
Impacted Files Coverage Δ
deepmd/entrypoints/test.py 11.67% <9.52%> (+0.87%) ⬆️
deepmd/utils/weight_avg.py 20.00% <20.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c667d00...2186788. Read the comment docs.

@amcadmus amcadmus merged commit f49c578 into deepmodeling:devel Apr 16, 2021
gzq942560379 pushed a commit to HPC-AI-Team/deepmd-kit that referenced this pull request Sep 1, 2021
seperate impl of averging errors across systems
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants