Skip to content

Bug fixings related to using validate dataset#523

Merged
amcadmus merged 4 commits intodeepmodeling:develfrom
amcadmus:devel
Apr 17, 2021
Merged

Bug fixings related to using validate dataset#523
amcadmus merged 4 commits intodeepmodeling:develfrom
amcadmus:devel

Conversation

@amcadmus
Copy link
Member

@amcadmus amcadmus commented Apr 16, 2021

Bug fixings:
1, when valid data is not given;
2, bug related to iterate over a dict.

Enhancement:
1, Not using ClassArg in trainer anymore
2, print name of the dataset in the summary of DeepmdDataSystem

…over a dict. Not using ClassArg in trainer anymore
@amcadmus amcadmus requested a review from ZiyaoLi April 16, 2021 12:18
@codecov-commenter
Copy link

Codecov Report

Merging #523 (90f744b) into devel (f49c578) will decrease coverage by 0.17%.
The diff coverage is 72.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel     #523      +/-   ##
==========================================
- Coverage   59.65%   59.48%   -0.18%     
==========================================
  Files          74       74              
  Lines        6177     6158      -19     
==========================================
- Hits         3685     3663      -22     
- Misses       2492     2495       +3     
Impacted Files Coverage Δ
deepmd/entrypoints/train.py 23.30% <0.00%> (ø)
deepmd/utils/data_system.py 68.06% <50.00%> (ø)
deepmd/train/trainer.py 38.70% <92.30%> (-0.64%) ⬇️
source/op/_tabulate_grad.py 57.14% <0.00%> (-9.53%) ⬇️
source/op/_gelu.py 71.42% <0.00%> (-6.35%) ⬇️
deepmd/loggers/loggers.py 40.59% <0.00%> (-1.99%) ⬇️
deepmd/env.py 81.15% <0.00%> (-1.45%) ⬇️
deepmd/loss/ener.py 7.55% <0.00%> (-0.41%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f49c578...90f744b. Read the comment docs.

@amcadmus amcadmus merged commit 09834fb into deepmodeling:devel Apr 17, 2021
gzq942560379 pushed a commit to HPC-AI-Team/deepmd-kit that referenced this pull request Sep 1, 2021
Bug fixings related to using validate dataset
njzjz pushed a commit to njzjz/deepmd-kit that referenced this pull request Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants