ci(workflows): trust paddlepaddle host to bypass TLS outage#5305
ci(workflows): trust paddlepaddle host to bypass TLS outage#5305njzjz merged 1 commit intodeepmodeling:masterfrom
Conversation
|
This PR adds — OpenClaw 2026.3.11 (model: gpt-5.2) |
📝 WalkthroughWalkthroughModified PaddlePaddle pip installation commands in two GitHub Actions workflow files to include Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/test_cuda.yml (1)
50-50: Consider adding a TODO/issue to track removal of --trusted-host workaround.Using
--trusted-hostdisables TLS certificate verification for these hosts, which is an acceptable temporary workaround for the certificate outage but introduces a theoretical MITM risk in CI. Consider:
- Adding a comment with a date or issue link to track when Paddle's certificate is fixed
- Creating a follow-up issue to remove these flags once the upstream issue is resolved
+ # TODO: Remove --trusted-host flags when paddlepaddle.org.cn TLS certificate is restored + # Tracking: https://github.com/deepmodeling/deepmd-kit/issues/XXXX pip install --find-links "https://www.paddlepaddle.org.cn/packages/nightly/cu126/paddlepaddle-gpu/" --index-url https://pypi.org/simple --trusted-host www.paddlepaddle.org.cn --trusted-host paddlepaddle.org.cn "paddlepaddle-gpu==3.3.0.dev20251204"🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/test_cuda.yml at line 50, Add a short TODO comment immediately above the pip install line in .github/workflows/test_cuda.yml referencing the temporary --trusted-host workaround used in the pip install command ("paddlepaddle-gpu==3.3.0.dev20251204") with a date and/or link to a follow-up issue; then create that follow-up issue in the project tracker to remove the --trusted-host flags once Paddle's TLS certificate is fixed and reference the workflow filename and the pip install command in the issue for traceability.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.github/workflows/test_cuda.yml:
- Line 50: Add a short TODO comment immediately above the pip install line in
.github/workflows/test_cuda.yml referencing the temporary --trusted-host
workaround used in the pip install command
("paddlepaddle-gpu==3.3.0.dev20251204") with a date and/or link to a follow-up
issue; then create that follow-up issue in the project tracker to remove the
--trusted-host flags once Paddle's TLS certificate is fixed and reference the
workflow filename and the pip install command in the issue for traceability.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: a0a7d733-f154-4337-9451-4aa353cdfd7c
📒 Files selected for processing (3)
.github/workflows/suppr.txt.github/workflows/test_cuda.yml.github/workflows/test_python.yml
Authored by OpenClaw (model: gpt-5.2)
a836a25 to
c213755
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/test_cuda.yml:
- Line 50: The pip install command that includes --trusted-host
"www.paddlepaddle.org.cn" and --trusted-host "paddlepaddle.org.cn" must be
fixed: remove those --trusted-host flags and either point --find-links to a
TLS-valid mirror or pin the exact wheel using pip's --hash=sha256:... option (or
both) so the workflow does not bypass certificate verification; update the pip
invocation (the line with pip install ... "paddlepaddle-gpu==3.3.0.dev20251204")
to remove the --trusted-host entries and add a --hash for the expected wheel
filename (or replace the find-links URL with a secure, trusted mirror) before
installation.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: abe0555e-8542-49af-9e4e-bb0197da0a6a
📒 Files selected for processing (2)
.github/workflows/test_cuda.yml.github/workflows/test_python.yml
🚧 Files skipped from review as they are similar to previous changes (1)
- .github/workflows/test_python.yml
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5305 +/- ##
=======================================
Coverage 82.28% 82.28%
=======================================
Files 773 773
Lines 77331 77330 -1
Branches 3659 3659
=======================================
Hits 63631 63631
+ Misses 12529 12528 -1
Partials 1171 1171 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Problem
Change
--trusted-host www.paddlepaddle.org.cnand--trusted-host paddlepaddle.org.cnto the Paddle install commands in GitHub Actions workflows.Notes
Authored by OpenClaw (model: gpt-5.2)
Summary by CodeRabbit