fix: statisitcs -> statistics#5315
Conversation
📝 WalkthroughWalkthroughThis PR corrects typographical errors in docstrings across descriptor modules (dpmodel, pd, pt, tf), mainly changing "statisitcs"/"statistitcs" to "statistics" and small wording fixes. No functional, signature, or control-flow changes were made. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can customize the high-level summary generated by CodeRabbit.Configure the |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@deepmd/tf/descriptor/hybrid.py`:
- Line 147: Rename the function parameter currently named "list" in hybrid.py
(the function starting near the top where that arg is declared) to avoid
shadowing the builtin (e.g., rename to "item_list" or "entries") and update all
internal references; in hybrid.py also rename the unused loop variable "idx" to
"_idx" where it appears around the loop near line 360. In se_r.py replace
mutable default arguments at the function(s) around lines 99 and 104 by using
None as the default and initialize the lists inside the function (e.g., if param
is None: param = [24,48,96] or param = []), and for the unpacked but unused
variables descrpt_deriv, rij, nlist around line 192 prefix them with an
underscore (e.g., _descrpt_deriv, _rij, _nlist) to silence the RUF059 warning.
In `@deepmd/tf/descriptor/se_atten.py`:
- Line 2365: Update the misspelled word in the docstring inside
deepmd/tf/descriptor/se_atten.py where the text currently reads "Reveive the
statistics (distance, max_nbor_size and env_mat_range) of the training data." —
change "Reveive" to "Receive" in that docstring so it reads "Receive the
statistics (distance, max_nbor_size and env_mat_range) of the training data."
Reference the docstring text to locate the exact spot to edit.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 0bcaa38a-c3fd-47c5-a96f-6766ba57ef4f
📒 Files selected for processing (18)
deepmd/dpmodel/descriptor/hybrid.pydeepmd/dpmodel/descriptor/make_base_descriptor.pydeepmd/pd/model/descriptor/dpa1.pydeepmd/pd/model/descriptor/se_a.pydeepmd/pt/model/descriptor/dpa1.pydeepmd/pt/model/descriptor/hybrid.pydeepmd/pt/model/descriptor/se_a.pydeepmd/pt/model/descriptor/se_r.pydeepmd/pt/model/descriptor/se_t.pydeepmd/tf/descriptor/descriptor.pydeepmd/tf/descriptor/hybrid.pydeepmd/tf/descriptor/loc_frame.pydeepmd/tf/descriptor/se_a.pydeepmd/tf/descriptor/se_a_ef.pydeepmd/tf/descriptor/se_a_mask.pydeepmd/tf/descriptor/se_atten.pydeepmd/tf/descriptor/se_r.pydeepmd/tf/descriptor/se_t.py
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5315 +/- ##
=======================================
Coverage 82.29% 82.30%
=======================================
Files 775 775
Lines 77627 77627
Branches 3676 3675 -1
=======================================
+ Hits 63887 63888 +1
Misses 12566 12566
+ Partials 1174 1173 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This PR fixes a typo pattern.
Summary by CodeRabbit