Skip to content

chore(pre-commit): remove flake8 hook#5324

Merged
njzjz merged 1 commit intodeepmodeling:masterfrom
njzjz-bot:chore/remove-flake8-precommit
Mar 17, 2026
Merged

chore(pre-commit): remove flake8 hook#5324
njzjz merged 1 commit intodeepmodeling:masterfrom
njzjz-bot:chore/remove-flake8-precommit

Conversation

@njzjz-bot
Copy link
Contributor

@njzjz-bot njzjz-bot commented Mar 17, 2026

Problem

  • flake8 is redundant with ruff in pre-commit and adds extra dependency/latency.

Change

  • Remove the flake8 repo hook from .pre-commit-config.yaml.

Authored by OpenClaw (model: gpt-5.2)

Summary by CodeRabbit

  • Chores
    • Removed Flake8 linting tool from the development pre-commit pipeline. This change reduces external dependencies and maintenance overhead for developers. The pre-commit pipeline continues to function normally with other configured quality checks remaining active.

Authored by OpenClaw (model: gpt-5.2)
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 17, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: a53ccfe6-9279-4b63-970a-6313d8e99365

📥 Commits

Reviewing files that changed from the base of the PR and between 4ce5c73 and 6f3041a.

📒 Files selected for processing (1)
  • .pre-commit-config.yaml
💤 Files with no reviewable changes (1)
  • .pre-commit-config.yaml

📝 Walkthrough

Walkthrough

This pull request removes the Flake8 pre-commit hook configuration from .pre-commit-config.yaml, including its rev specification and associated dependencies (torchfix and flake8-pyproject). The change removes 8 lines from the configuration file with no other modifications to the pre-commit pipeline.

Changes

Cohort / File(s) Summary
Pre-commit Configuration
.pre-commit-config.yaml
Removed Flake8 hook (rev 7.3.0) and its extra dependencies: torchfix==0.7.0 and flake8-pyproject==1.2.3.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

build

Suggested reviewers

  • iProzd
  • wanghan-iapcm
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removal of the flake8 hook from the pre-commit configuration, which is the sole modification in this changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can use TruffleHog to scan for secrets in your code with verification capabilities.

Add a TruffleHog config file (e.g. trufflehog-config.yml, trufflehog.yml) to your project to customize detectors and scanning behavior. The tool runs only when a config file is present.

@njzjz njzjz enabled auto-merge March 17, 2026 15:23
@codecov
Copy link

codecov bot commented Mar 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.29%. Comparing base (4ce5c73) to head (6f3041a).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5324      +/-   ##
==========================================
- Coverage   82.30%   82.29%   -0.01%     
==========================================
  Files         775      775              
  Lines       77628    77627       -1     
  Branches     3675     3675              
==========================================
- Hits        63888    63886       -2     
+ Misses      12568    12566       -2     
- Partials     1172     1175       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@njzjz njzjz added this pull request to the merge queue Mar 17, 2026
Merged via the queue into deepmodeling:master with commit 87b1fff Mar 17, 2026
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants