Skip to content

feat(pretrained): add DPA3-Omol-Large#5327

Queued
njzjz-bot wants to merge 2 commits intodeepmodeling:masterfrom
njzjz-bothub:feat/add-dpa3-omol-large
Queued

feat(pretrained): add DPA3-Omol-Large#5327
njzjz-bot wants to merge 2 commits intodeepmodeling:masterfrom
njzjz-bothub:feat/add-dpa3-omol-large

Conversation

@njzjz-bot
Copy link
Contributor

@njzjz-bot njzjz-bot commented Mar 18, 2026

Problem

  • DPA3-Omol-Large is already published on model hubs but is not exposed through dp pretrained.
  • Users currently cannot download or resolve it via a built-in model alias.

Change

  • add DPA3-Omol-Large to the built-in pretrained model registry
  • include Hugging Face / hf-mirror / ModelScope download URLs and the model sha256
  • update the pretrained-model docs and add alias/backend coverage in tests

Notes

  • The SHA256 (dc4d252b31450b41eb3546cc48f640ad0831c0b5d069ce27d996e0ff58fc037a) was taken from the Hugging Face LFS object for DPA3-Omol-Large.pt.
  • In this environment I only ran lightweight local validation (py_compile + an AST-based registry check). I did not run the full project test suite because the repo test environment was not fully provisioned here.

Authored by OpenClaw (model: gpt-5.4)

Summary by CodeRabbit

  • New Features

    • Added "DPA3-Omol-Large" as a new pretrained model, available from multiple download mirrors for improved accessibility and reliability.
  • Documentation

    • Updated pretrained model examples to include "DPA3-Omol-Large".
  • Tests

    • Added tests to validate recognition and alias normalization for the new model name.

Problem
- DPA3-Omol-Large is published on model hubs but is not available via dp pretrained.
- Users cannot reference the model by built-in alias from DeePMD-kit.

Change
- register DPA3-Omol-Large in the built-in pretrained model registry
- document the new built-in model and cover alias/backend resolution in tests

Notes
- sha256 taken from the Hugging Face LFS object for DPA3-Omol-Large.pt
- lightweight local validation only: py_compile + registry AST check

Authored by OpenClaw (model: gpt-5.4)
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 18, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: fc3e81aa-7769-4a49-8c0d-a8bdf7b9cfeb

📥 Commits

Reviewing files that changed from the base of the PR and between 9045145 and cfd38f7.

📒 Files selected for processing (1)
  • source/tests/common/test_pretrained_backend.py

📝 Walkthrough

Walkthrough

Adds a new pretrained model entry "DPA3-Omol-Large" to the model registry with download URLs and SHA256, updates pretrained docs to list the model, and adds tests for backend detection and alias parsing for the new model.

Changes

Cohort / File(s) Summary
Model Registry
deepmd/pretrained/registry.py
Added DPA3-Omol-Large entry to MODEL_REGISTRY with three download URLs, filename and sha256.
Documentation
doc/model/pretrained.md
Added DPA3-Omol-Large to the Examples section of pretrained models documentation.
Test Coverage
source/tests/common/test_pretrained_backend.py
Added tests test_detect_backend_by_new_model_name() and test_parse_pretrained_alias_new_model_name() to verify backend detection and alias normalization for the new model.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • njzjz
  • iProzd
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'feat(pretrained): add DPA3-Omol-Large' directly and clearly summarizes the main change: adding a new pretrained model to the registry.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can use TruffleHog to scan for secrets in your code with verification capabilities.

Add a TruffleHog config file (e.g. trufflehog-config.yml, trufflehog.yml) to your project to customize detectors and scanning behavior. The tool runs only when a config file is present.

Problem
- pre-commit reformatted the new pretrained backend test and left the branch dirty.

Change
- apply the ruff-format output for the new DPA3-Omol-Large test coverage

Notes
- trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...............................................................Passed
check json...............................................................Passed
check for added large files..............................................Passed
check for merge conflicts................................................Passed
check for broken symlinks................................................Passed
check toml...............................................................Passed
isort....................................................................Passed
ruff (legacy alias)......................................................Passed
ruff format..............................................................Passed
Velin....................................................................Passed
mdformat.................................................................Passed
clang-format.............................................................Passed
prettier.................................................................Passed
shfmt....................................................................Passed
cmake-format.............................................................Passed
bibtex-tidy..............................................................Passed
Insert license in comments...............................................Passed
Insert license in comments...............................................Passed
Insert license in comments...............................................Passed
Insert license in comments...............................................Passed
Disallow improper capitalization.........................................Passed
pylint...................................................................Passed passes after this commit

Authored by OpenClaw (model: gpt-5.4)
@iProzd iProzd enabled auto-merge March 18, 2026 13:37
@codecov
Copy link

codecov bot commented Mar 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.30%. Comparing base (3ab3779) to head (cfd38f7).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5327   +/-   ##
=======================================
  Coverage   82.30%   82.30%           
=======================================
  Files         775      775           
  Lines       77663    77663           
  Branches     3677     3676    -1     
=======================================
  Hits        63923    63923           
  Misses      12566    12566           
  Partials     1174     1174           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@iProzd iProzd added this pull request to the merge queue Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants