remove typing_extensions for python>=3.7#752
Merged
amcadmus merged 1 commit intodeepmodeling:develfrom Jun 15, 2021
Merged
Conversation
We don't need typing_extensions for python>=3.7. See: [1] https://pypi.org/project/typing-extensions/ [2] https://www.python.org/dev/peps/pep-0508/
Codecov Report
@@ Coverage Diff @@
## devel #752 +/- ##
=======================================
Coverage 74.21% 74.21%
=======================================
Files 82 82
Lines 6520 6520
=======================================
Hits 4839 4839
Misses 1681 1681 Continue to review full report at Codecov.
|
gzq942560379
pushed a commit
to HPC-AI-Team/deepmd-kit
that referenced
this pull request
Sep 1, 2021
We don't need typing_extensions for python>=3.7. See: [1] https://pypi.org/project/typing-extensions/ [2] https://www.python.org/dev/peps/pep-0508/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't need typing_extensions for python>=3.7.
See:
[1] https://pypi.org/project/typing-extensions/
[2] https://www.python.org/dev/peps/pep-0508/