Skip to content

throw a message if tf runtime is incompatible#797

Merged
amcadmus merged 8 commits intodeepmodeling:develfrom
njzjz:tf_version2
Jun 26, 2021
Merged

throw a message if tf runtime is incompatible#797
amcadmus merged 8 commits intodeepmodeling:develfrom
njzjz:tf_version2

Conversation

@njzjz
Copy link
Member

@njzjz njzjz commented Jun 25, 2021

fix #406, #447, #557, #774 and #796.

This was linked to issues Jun 25, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2021

Codecov Report

Merging #797 (ac58443) into devel (4555034) will decrease coverage by 0.08%.
The diff coverage is 52.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel     #797      +/-   ##
==========================================
- Coverage   74.05%   73.96%   -0.09%     
==========================================
  Files          84       84              
  Lines        6576     6588      +12     
==========================================
+ Hits         4870     4873       +3     
- Misses       1706     1715       +9     
Impacted Files Coverage Δ
deepmd/env.py 74.07% <52.38%> (-8.54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4555034...ac58443. Read the comment docs.

Copy link
Member

@amcadmus amcadmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR checks the compile-time TF version with the run-time TF version, and raise a runtime error if the versions do not match.

However, sometimes in compatible compile-time and run-time TF versions are allowed, do I understand it correctly? If so, we should raise an warning message rather than an error.

Copy link
Member

@amcadmus amcadmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with most of the changes made by this PR, except one thing described below

This PR checks the compile-time TF version with the run-time TF version, and raise a runtime error if the versions do not match.

However, sometimes in compatible compile-time and run-time TF versions are allowed, do I understand it correctly? If so, we should raise an warning message rather than an error.

@amcadmus
Copy link
Member

I agree with most of the changes made by this PR, except one thing described below

This PR checks the compile-time TF version with the run-time TF version, and raise a runtime error if the versions do not match.

However, sometimes in compatible compile-time and run-time TF versions are allowed, do I understand it correctly? If so, we should raise an warning message rather than an error.

outdated, please ignore this review

@amcadmus amcadmus merged commit b145ca3 into deepmodeling:devel Jun 26, 2021
@njzjz njzjz deleted the tf_version2 branch June 26, 2021 17:18
gzq942560379 pushed a commit to HPC-AI-Team/deepmd-kit that referenced this pull request Sep 2, 2021
* throw a message if tf runtime is incompatible

fix deepmodeling#557 and deepmodeling#796.

* still raise if tf version is correct

* detect TF_CXX11_ABI_FLAG

* format codes

* fix lint

* move messages into the function

* fix lint

* fix lints
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants