Skip to content

set input DeepmdData.type_map to input type_map#924

Merged
amcadmus merged 1 commit intodeepmodeling:develfrom
amcadmus:fix-920
Aug 6, 2021
Merged

set input DeepmdData.type_map to input type_map#924
amcadmus merged 1 commit intodeepmodeling:develfrom
amcadmus:fix-920

Conversation

@amcadmus
Copy link
Member

@amcadmus amcadmus commented Aug 5, 2021

This fixes #920

@amcadmus amcadmus requested review from njzjz and yhliu918 August 5, 2021 12:09
@codecov-commenter
Copy link

Codecov Report

Merging #924 (eb2efb8) into devel (ee0ed99) will decrease coverage by 11.13%.
The diff coverage is n/a.

❗ Current head eb2efb8 differs from pull request most recent head 3337e3b. Consider uploading reports for the commit 3337e3b to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##            devel     #924       +/-   ##
===========================================
- Coverage   75.42%   64.28%   -11.14%     
===========================================
  Files          85        5       -80     
  Lines        6730       14     -6716     
===========================================
- Hits         5076        9     -5067     
+ Misses       1654        5     -1649     
Impacted Files Coverage Δ
deepmd/fit/dipole.py
deepmd/model/ener.py
deepmd/utils/network.py
deepmd/utils/sess.py
deepmd/descriptor/hybrid.py
deepmd/entrypoints/convert.py
deepmd/fit/ener.py
deepmd/entrypoints/freeze.py
source/op/_prod_virial_se_a_grad.py
deepmd/descriptor/loc_frame.py
... and 69 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee0ed99...3337e3b. Read the comment docs.

@njzjz
Copy link
Member

njzjz commented Aug 5, 2021

@tuoping: It seems that our document does not mention that the type_map in all systems should be the same.

@amcadmus
Copy link
Member Author

amcadmus commented Aug 6, 2021

@tuoping: It seems that our document does not mention that the type_map in all systems should be the same.

We do not need to set the type_map in all data systems the same.

@njzjz
Copy link
Member

njzjz commented Aug 6, 2021

Got it. I just understood the logic.

@amcadmus amcadmus merged commit 4ced020 into deepmodeling:devel Aug 6, 2021
@amcadmus amcadmus deleted the fix-920 branch August 6, 2021 07:04
gzq942560379 pushed a commit to HPC-AI-Team/deepmd-kit that referenced this pull request Sep 2, 2021
Co-authored-by: Han Wang <wang_han@iapcm.ac.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants