Skip to content

add model compression support for models without training script#948

Merged
amcadmus merged 6 commits intodeepmodeling:develfrom
denghuilu:support-old-compression
Aug 11, 2021
Merged

add model compression support for models without training script#948
amcadmus merged 6 commits intodeepmodeling:develfrom
denghuilu:support-old-compression

Conversation

@denghuilu
Copy link
Member

@denghuilu denghuilu commented Aug 11, 2021

Add model compression support for models without training script. The main changes are:

  • Allow users to provide the training script if there's no training script within the input frozen model.
  • Note if there's a training script within the frozen model and the users provide one at the same time, the training script within the model will be used by default.

@denghuilu denghuilu requested review from amcadmus and njzjz August 11, 2021 07:27
@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2021

Codecov Report

Merging #948 (3479694) into devel (c4856ef) will decrease coverage by 7.85%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel     #948      +/-   ##
==========================================
- Coverage   83.34%   75.49%   -7.86%     
==========================================
  Files         118       80      -38     
  Lines        9956     6770    -3186     
==========================================
- Hits         8298     5111    -3187     
- Misses       1658     1659       +1     
Impacted Files Coverage Δ
deepmd/entrypoints/compress.py 80.76% <30.00%> (-10.35%) ⬇️
deepmd/entrypoints/train.py 87.19% <71.42%> (-0.78%) ⬇️
deepmd/entrypoints/main.py 88.42% <100.00%> (+0.12%) ⬆️
source/lib/tests/test_prod_force_a.cc
source/lib/tests/test_soft_min_switch_virial.cc
source/lib/tests/test_pair_tab.cc
source/lib/tests/test_prod_virial_grad_a.cc
source/lib/tests/test_prod_virial_r.cc
source/api_cc/tests/test_deeppolar.cc
source/api_cc/include/DataModifier.h
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4856ef...3479694. Read the comment docs.

@amcadmus amcadmus merged commit e8a9101 into deepmodeling:devel Aug 11, 2021
gzq942560379 pushed a commit to HPC-AI-Team/deepmd-kit that referenced this pull request Sep 2, 2021
…pmodeling#948)

* add model compression support for models without training script

* fix line changes

* update doc for model compression

* make the error message more reasonable

* update doc for model compression
njzjz added a commit to njzjz/deepmd-kit that referenced this pull request Sep 21, 2023
This file is useless during installation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants