Skip to content

fix bug of duplicated atom names in vasp output#250

Merged
wanghan-iapcm merged 8 commits intodeepmodeling:develfrom
amcadmus:fix-248
Feb 26, 2022
Merged

fix bug of duplicated atom names in vasp output#250
wanghan-iapcm merged 8 commits intodeepmodeling:develfrom
amcadmus:fix-248

Conversation

@amcadmus
Copy link
Member

@amcadmus amcadmus commented Feb 25, 2022

Fixes #248

@amcadmus amcadmus requested a review from njzjz February 25, 2022 03:17
@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.09%. Comparing base (b62f67a) to head (898a856).
Report is 353 commits behind head on devel.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #250      +/-   ##
==========================================
+ Coverage   82.00%   82.09%   +0.09%     
==========================================
  Files          59       60       +1     
  Lines        5124     5150      +26     
==========================================
+ Hits         4202     4228      +26     
  Misses        922      922              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wanghan-iapcm wanghan-iapcm merged commit 2c90f17 into deepmodeling:devel Feb 26, 2022
@amcadmus amcadmus deleted the fix-248 branch February 26, 2022 12:26
@kimiaGF
Copy link

kimiaGF commented Mar 3, 2022

I noticed the branch was merged, has this been fixed? Should I now build from source to be able to use the updated files?

@wanghan-iapcm
Copy link
Contributor

I noticed the branch was merged, has this been fixed? Should I now build from source to be able to use the updated files?

Yes please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants