support -1 shape in DataType#510
Merged
wanghan-iapcm merged 2 commits intodeepmodeling:develfrom Jul 26, 2023
Merged
Conversation
for more information, see https://pre-commit.ci
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## devel #510 +/- ##
==========================================
+ Coverage 82.75% 82.77% +0.01%
==========================================
Files 71 71
Lines 6421 6428 +7
==========================================
+ Hits 5314 5321 +7
Misses 1107 1107
☔ View full report in Codecov by Sentry. |
njzjz
changed the title
-1 shape in DataType (#62)-1 shape in DataType
wanghan-iapcm
approved these changes
Jul 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes, the shape is unknown and can be any integer. This PR supports this situation. The shape of a dimension can be
-1.Note: Only one
-1can be used.