Fix: remove the reading of ntype when treating ABACUS related info#1075
Merged
wanghan-iapcm merged 1 commit intodeepmodeling:develfrom Dec 18, 2022
Merged
Fix: remove the reading of ntype when treating ABACUS related info#1075wanghan-iapcm merged 1 commit intodeepmodeling:develfrom
ntype when treating ABACUS related info#1075wanghan-iapcm merged 1 commit intodeepmodeling:develfrom
Conversation
Contributor
Author
|
The failed unit test is caused by dpdata, I have made the similar fix in dpdata (deepmodeling/dpdata#394), We need to wait that PR to be merged and a new version of dpdata to be released. |
Contributor
|
Dear @pxlxingliang the new version of dpdata is released https://github.com/deepmodeling/dpdata/releases/tag/0.2.13 |
Contributor
Author
|
Dear @wanghan-iapcm, thanks! |
wanghan-iapcm
approved these changes
Dec 18, 2022
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #1075 +/- ##
==========================================
- Coverage 39.49% 39.30% -0.19%
==========================================
Files 99 99
Lines 17998 17976 -22
==========================================
- Hits 7108 7066 -42
- Misses 10890 10910 +20 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest ABACUS 3.0.5 have removed the key word ·ntype·