Skip to content

generate run arg doc from scripts#747

Merged
AnguseZhang merged 10 commits intodeepmodeling:develfrom
njzjz:run_args
Jul 5, 2022
Merged

generate run arg doc from scripts#747
AnguseZhang merged 10 commits intodeepmodeling:develfrom
njzjz:run_args

Conversation

@njzjz
Copy link
Member

@njzjz njzjz commented Jun 8, 2022

This commit generates run argument documentation from scripts (inited by @LiangWenshuo1118) at runtime, so we can work together on the script to improve the docs.

I see some arguments are still missing here...

This commit generates run argument documentations from scripts at runtime, so we can work on the script to improve the docs.
@njzjz njzjz added the documentation Improvements or additions to documentation label Jun 8, 2022
Copy link
Collaborator

@AnguseZhang AnguseZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@njzjz Great work! @LiangWenshuo1118 Please help check.

@njzjz
Copy link
Member Author

njzjz commented Jun 10, 2022

Removed init_multi_systems considering #730 has been merged.

@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2022

Codecov Report

Merging #747 (be17e21) into devel (bace57e) will decrease coverage by 0.20%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##            devel     #747      +/-   ##
==========================================
- Coverage   34.81%   34.60%   -0.21%     
==========================================
  Files          96       96              
  Lines       16633    16733     +100     
==========================================
  Hits         5790     5790              
- Misses      10843    10943     +100     
Impacted Files Coverage Δ
dpgen/generator/arginfo.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bace57e...be17e21. Read the comment docs.

@njzjz njzjz marked this pull request as draft June 11, 2022 04:52
@njzjz njzjz marked this pull request as ready for review June 11, 2022 04:58
@njzjz
Copy link
Member Author

njzjz commented Jun 11, 2022

Switched to new dargs directive.

@njzjz njzjz marked this pull request as draft June 11, 2022 08:03
@njzjz
Copy link
Member Author

njzjz commented Jun 11, 2022

The following is missing:

  • training
    • training_reuse_iter
    • training_reuse_old_ratio
    • training_reuse_stop_batch
    • training_reuse_numb_steps
    • training_reuse_start_lr
    • training_reuse_start_pref_e
    • training_reuse_start_pref_f
  • model devi
    • gromacs
    • amber
    • calypso
    • revise_template
    • buffet
  • fp
    • pwmat
    • abacus
    • amber/diff
    • some parameters of gaussian

Considering it's too much, we may submit separated PRs to add them.

@njzjz njzjz marked this pull request as ready for review June 11, 2022 08:19
@njzjz njzjz assigned njzjz and unassigned njzjz Jun 11, 2022
@AnguseZhang AnguseZhang requested a review from HuangJiameng July 1, 2022 02:48
@AnguseZhang AnguseZhang merged commit fd07f19 into deepmodeling:devel Jul 5, 2022
@njzjz njzjz deleted the run_args branch July 6, 2022 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

No open projects
Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

5 participants