Example_dp2.x_lmp_gaussian#887
Merged
wanghan-iapcm merged 10 commits intodeepmodeling:develfrom Aug 21, 2022
Merged
Conversation
Signed-off-by: ziqi-hu <51811006+ziqi-hu@users.noreply.github.com>
wanghan-iapcm
requested changes
Aug 18, 2022
Contributor
wanghan-iapcm
left a comment
wanghan-iapcm
left a comment
There was a problem hiding this comment.
Could you please check the new examples by test_check_examples.py? We do not want to manually check them.
Collaborator
|
It seems that you bring the changes when you switch to this branch. |
Member
|
Please fix the errors reported by the unit test. You can firstly test on your local machine before pushing commits. |
njzjz
requested changes
Aug 19, 2022
add ratio_failed for fp_style_gaussian_args. Signed-off-by: ziqi-hu <51811006+ziqi-hu@users.noreply.github.com>
delete init_multi_systems Signed-off-by: ziqi-hu <51811006+ziqi-hu@users.noreply.github.com>
delete init_multi_systems from param.json Signed-off-by: ziqi-hu <51811006+ziqi-hu@users.noreply.github.com>
njzjz
reviewed
Aug 19, 2022
Remove the changes in deepmodeling#885 Signed-off-by: ziqi-hu <51811006+ziqi-hu@users.noreply.github.com>
add ratio_failed for fp_style_gaussian_args Signed-off-by: ziqi-hu <51811006+ziqi-hu@users.noreply.github.com>
Remove “fp_pp_path” and “fp_pp_files” Signed-off-by: ziqi-hu <51811006+ziqi-hu@users.noreply.github.com>
wanghan-iapcm
approved these changes
Aug 21, 2022
Codecov Report
@@ Coverage Diff @@
## devel #887 +/- ##
==========================================
+ Coverage 38.12% 38.14% +0.02%
==========================================
Files 99 99
Lines 17782 17767 -15
==========================================
- Hits 6779 6778 -1
+ Misses 11003 10989 -14
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
njzjz
approved these changes
Aug 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.