fix: remove lmp_traj from forward_files in run_md_model_devi#944
Merged
wanghan-iapcm merged 1 commit intodeepmodeling:develfrom Sep 13, 2022
Merged
Conversation
Collaborator
Author
|
This fix aims to solve the problem mentioned in #938. |
Codecov Report
@@ Coverage Diff @@
## devel #944 +/- ##
=======================================
Coverage 38.16% 38.16%
=======================================
Files 99 99
Lines 17885 17885
=======================================
Hits 6825 6825
Misses 11060 11060
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
wanghan-iapcm
approved these changes
Sep 13, 2022
Member
|
This PR is incorrect - LAMMPS will throw errors when the directory does not exist. |
Contributor
|
@HuangJiameng have you really tested this PR? |
Collaborator
Author
|
I have tested it with |
Collaborator
Author
This error will occur when |
njzjz
pushed a commit
that referenced
this pull request
Sep 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lmp_trajshould not be inforward_filesinrun_model_devistep.