fix calc space bug#91
Merged
beginlner merged 2 commits intodeepseek-ai:mainfrom Aug 27, 2025
Merged
Conversation
Collaborator
|
LGTM, Thanks! |
Contributor
|
Hi, @uchihatmtkinu |
Collaborator
Author
|
Hi @SeanLi-OI, I'm working on the optimization of buffer usage in backward. Hopefully, it will be done before next weekend. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
workspace_byteswill be overlimit with large batch_size and max_seq_len sinceB,H,Qareint32_tand can easily reach the upper bound. Changing the order will fix this assizeof(xx)isuint64_t. This bug is coming from the 77 example of cutlass codebase. It will also be fixed in cutlass.The workspace will be much more wasted and could be optimized when the variance of the seqlens is large. But at least it won't cause error with this PR. I will improve it in future.
I also notice the performance of backward kernel is dropped during this scenario(large variance in seqlens), I will try to optimize it as well.