Skip to content

bug: fix default search_param in milvus.py #4683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hyunsir wants to merge 1 commit into from
Closed

bug: fix default search_param in milvus.py #4683

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions haystack/document_stores/milvus.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ def __init__(
For example: {"nlist": 16384} as the number of cluster units to create for index_type IVF_FLAT.
See https://milvus.io/docs/v2.0.x/index.md
:param search_param: Configuration parameters for the chose index_type needed at query time
For example: {"nprobe": 10} as the number of cluster units to query for index_type IVF_FLAT.
For example: {"params": {"nprobe": 10}} as the number of cluster units to query for index_type IVF_FLAT.
See https://milvus.io/docs/v2.0.x/index.md
:param return_embedding: To return document embedding.
:param embedding_field: Name of field containing an embedding vector.
Expand Down Expand Up @@ -171,7 +171,7 @@ def __init__(

self.index_type = index_type
self.index_param = index_param or {"nlist": 16384}
self.search_param = search_param or {"nprobe": 10}
self.search_param = search_param or {"params": {"nprobe": 10}}
self.index = index
self.embedding_field = embedding_field
self.id_field = id_field
Expand Down