Skip to content

removed restrictions for custom optimizer #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ShadenSmith merged 3 commits into from
Mar 22, 2020
Merged

removed restrictions for custom optimizer #161

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bf1d0e3
removed restrictions for custom optimizer
Mar 20, 2020
2f07f41
fixed yapf missformatting
Mar 20, 2020
eb573e2
Merge branch 'master' into custom_optimizer
Mar 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion deepspeed/pt/deepspeed_light.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,7 +441,11 @@ def _configure_optimizer(self, client_optimizer, model_parameters):

logging.info('DeepSpeed Basic Optimizer = {}'.format(basic_optimizer))

if self.zero_optimization() and self.optimizer_name() == ADAM_OPTIMIZER:
if self.zero_optimization():
if self.optimizer_name != ADAM_OPTIMIZER:
logging.warning(
"**** You are using ZeRO with an untested optimizer, proceed with caution *****"
)
self.optimizer = self._configure_zero_optimizer(basic_optimizer)
elif self.fp16_enabled():
self.optimizer = self._configure_fp16_optimizer(basic_optimizer)
Expand Down