Merged
Conversation
|
Can one of the admins verify this patch? |
Sanger2000
requested review from
RezaYazdaniAminabadi,
ShadenSmith,
awan-10,
cli99,
conglongli,
eltonzheng,
jeffra,
minjiaz,
samyam and
tjruwase
as code owners
Contributor
Author
|
It's a pretty minor change, but let me know if it makes sense. |
jeffra
requested review from
arashb,
duli2012,
mrwyattii,
xiaoxiawu-microsoft and
yaozhewei
as code owners
jeffra
approved these changes
Jun 16, 2022
Collaborator
jeffra
left a comment
jeffra
left a comment
There was a problem hiding this comment.
LGTM. Thank you for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DeepSpeedDataLoader currently has a length equal to the length of the dataset passed in. I made a small change such that its length is equal to the number of batches in the data loader (the same way it is done in pytorch).
An alternative change could be to set the length equal to
len(self.data)afterself._create_dataloader()is called.