Skip to content

fixing the dataloader original len issue#178

Closed
tomekrut wants to merge 3 commits intodeepspeedai:masterfrom
tomekrut:master
Closed

fixing the dataloader original len issue#178
tomekrut wants to merge 3 commits intodeepspeedai:masterfrom
tomekrut:master

Conversation

@tomekrut
Copy link
Copy Markdown

This is related to issue #176

@msftclas
Copy link
Copy Markdown

msftclas commented Mar 31, 2020

CLA assistant check
All CLA requirements met.

@tjruwase
Copy link
Copy Markdown
Contributor

tjruwase commented Mar 31, 2020

Thanks! This is looks great.
Can you please add some unit tests? To cover

  1. Batch mode
  2. Non-batch mode
  3. Multiple epochs

You can refer to tests/unit for examples of unit tests and this guide.

@jeffra
Copy link
Copy Markdown
Collaborator

jeffra commented May 5, 2020

@tomekrut are you able to sign the contributor license agreement? Would love to merge your contribution soon! :)

@tomekrut
Copy link
Copy Markdown
Author

tomekrut commented May 6, 2020

@tomekrut are you able to sign the contributor license agreement? Would love to merge your contribution soon! :)

Hi @jeffra - are you ok with that? Do you write unit test for things like that as well? If so, I can look at it but most likely Friday / Monday.

jeffra added a commit that referenced this pull request Apr 19, 2021
Co-authored-by: Shaden Smith <Shaden.Smith@microsoft.com>
Co-authored-by: Reza Yazdani <44502768+RezaYazdaniAminabadi@users.noreply.github.com>
Co-authored-by: Cheng Li <pistasable@gmail.com>
Co-authored-by: Samyam Rajbhandari <samyamr@microsoft.com>
Co-authored-by: Shaden Smith <Shaden.Smith@microsoft.com>
Co-authored-by: Jeff Rasley <jerasley@microsoft.com>
Co-authored-by: Olatunji Ruwase <olruwase@microsoft.com>
Co-authored-by: Shaden Smith <ShadenTSmith@gmail.com>
Co-authored-by: eltonzheng <eltonz@microsoft.com>
Co-authored-by: Jeff Rasley <jerasley@microsoft.com>
Co-authored-by: Stas Bekman <stas00@users.noreply.github.com>
Co-authored-by: Cheng Li <pistasable@gmail.com>
Co-authored-by: Olatunji Ruwase <olruwase@microsoft.com>
Co-authored-by: Reza Yazdani <44502768+RezaYazdaniAminabadi@users.noreply.github.com>
Co-authored-by: Samyam Rajbhandari <samyamr@microsoft.com>
Co-authored-by: eltonzheng <eltonz@microsoft.com>
Co-authored-by: Olatunji Ruwase <olruwase@microsoft.com>
Co-authored-by: Shaden Smith <Shaden.Smith@microsoft.com>
Co-authored-by: Stas Bekman <stas00@users.noreply.github.com>
Co-authored-by: Cheng Li <pistasable@gmail.com>
Co-authored-by: Reza Yazdani <44502768+RezaYazdaniAminabadi@users.noreply.github.com>
Co-authored-by: Samyam Rajbhandari <samyamr@microsoft.com>
Co-authored-by: eltonzheng <eltonz@microsoft.com>
Co-authored-by: Olatunji Ruwase <olruwase@microsoft.com>
Co-authored-by: Jeff Rasley <jerasley@microsoft.com>
Co-authored-by: Olatunji Ruwase <olruwase@microsoft.com>
Co-authored-by: Shaden Smith <Shaden.Smith@microsoft.com>
Co-authored-by: Reza Yazdani <44502768+RezaYazdaniAminabadi@users.noreply.github.com>
Co-authored-by: Cheng Li <pistasable@gmail.com>
Co-authored-by: Samyam Rajbhandari <samyamr@microsoft.com>
Co-authored-by: Olatunji Ruwase <olruwase@microsoft.com>
Co-authored-by: Shaden Smith <ShadenTSmith@gmail.com>
Co-authored-by: eltonzheng <eltonz@microsoft.com>
Co-authored-by: Stas Bekman <stas00@users.noreply.github.com>
@rocm-mici
Copy link
Copy Markdown

Can one of the admins verify this patch?

@jeffra jeffra closed this Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants