Fix issue with corrupted output on long generation for GPT#2344
Closed
andrewchernyh wants to merge 2 commits intodeepspeedai:masterfrom
Closed
Fix issue with corrupted output on long generation for GPT#2344andrewchernyh wants to merge 2 commits intodeepspeedai:masterfrom
andrewchernyh wants to merge 2 commits intodeepspeedai:masterfrom
Conversation
Contributor
Author
|
Not actual more, see #2300 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue described in #2300
Only updating MAX_OUT_TOKES doesn't helps and main issue is in temp_buf that was allocated just after
outputtensorThen in
attention_unfusedT* workspace = (T*)output + bsz * seq_len * heads * k;where output istemp_buffromds_softmax_contextIn the result
temp_bufoverlapsquery_contallocated inds_softmax_contextI've put
temp_bufjust afterkv_cacheand it helpsMinimal steps to reproduce: