zero.Init() should pin params in GPU memory as requested #2953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…osoft/DeepSpeed into olruwase/zero_infer_partial_offload
…osoft/DeepSpeed into olruwase/zero_infer_partial_offload
…osoft/DeepSpeed into olruwase/zero_infer_partial_offload
…osoft/DeepSpeed into olruwase/zero_infer_partial_offload
…osoft/DeepSpeed into olruwase/zero_infer_partial_offload
mrwyattii
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
zero.Init()will offload all parameters even if user requested some to be pinned in GPU memory (using*_persistence_thresholdconfigs). Those params are eventually pinned into GPU memory after the first forward pass. Unfortunately,zero.Init()may fail CPU OOM which could be avoided by utilizing GPU and CPU memory per user request.This PR avoids this problem and improves flexibility of combining GPU and CPU memory.