Conversation
Contributor
|
@jomayeri, please add some unit tests |
tjruwase
reviewed
Jun 18, 2024
tjruwase
reviewed
Jun 18, 2024
tjruwase
reviewed
Jun 18, 2024
tjruwase
reviewed
Jul 16, 2024
tjruwase
reviewed
Jul 16, 2024
tjruwase
reviewed
Jul 16, 2024
tjruwase
approved these changes
Aug 7, 2024
tjruwase
reviewed
Aug 7, 2024
|
|
||
|
|
||
| @contextmanager | ||
| def unwrap_model_for_generation(model): |
Contributor
There was a problem hiding this comment.
It seems my comment here was missed?
Suggested change
| def unwrap_model_for_generation(model): | |
| def unshard_and_remove_hooks(model): |
Contributor
|
@jomayeri, can you please add documentation of this new API somewhere below? |
mauryaavinash95
pushed a commit
to DataStates/DeepSpeed
that referenced
this pull request
Mar 20, 2025
Gives the ability to add and remove the forward hooks in ZeRO 3 by using a context manager. These code changes were taken from a Huggingface [PR](huggingface/trl#1617) and integrated for direct support in DeepSpeed. This is useful in the inference case and the speedup can be observed [here](huggingface/trl#1483). --------- Co-authored-by: root <root@deepspeed-c000004.2d1icxc5dsxehnpuwt3ifc34ph.gvxx.internal.cloudapp.net> Co-authored-by: Olatunji Ruwase <olruwase@microsoft.com> Co-authored-by: Heyang Qin <heyangqin@microsoft.com> Co-authored-by: Logan Adams <loadams@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gives the ability to add and remove the forward hooks in ZeRO 3 by using a context manager. These code changes were taken from a Huggingface PR and integrated for direct support in DeepSpeed.
This is useful in the inference case and the speedup can be observed here.