Conversation
stas00
requested review from
RezaYazdaniAminabadi,
ShadenSmith,
arashashari,
awan-10,
cli99,
conglongli,
eltonzheng,
jeffra,
minjiaz,
niumanar,
samyam and
tjruwase
as code owners
Collaborator
|
Thanks @stas00! I pushed one update to switch from 500000000 -> 5e8 across both the zero and config docs. I think even if we switch to hjson it doesn't support 500_000_000 style so we're probably best using 5e8 style going forward for numbers. I think we will probably switch to hjson soon, it's a backwards compatible change so should be relatively easy/painless. |
jeffra
approved these changes
Jan 20, 2021
Collaborator
Author
|
Fantastic! This is definitely a welcome change! Thank you, @jeffra! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes several typos, incomplete sentences and several incorrect statements.
As you can tell no human can read 50000000 and so the author made a mistake of explaining it as 50M, when it should be 500M. (fixed). Unless you switch to hjson as we have been discussing elsewhere, perhaps it'd be better to just replace
50000000with5e8in the documentation.p.s. my editor is setup to clean trailing space, so a small part of the diff is that - please let me know if that's inefficient and I will make sure future PRs will avoid whitespace changes.