Skip to content

Fix TOCTOU issues, switch to fstat #7067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tjruwase merged 1 commit into from
Feb 24, 2025
Merged

Fix TOCTOU issues, switch to fstat #7067

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions csrc/aio/common/deepspeed_aio_common.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,12 +284,13 @@ int open_file(const char* filename, const bool read_op)

int regular_read(const char* filename, std::vector<char>& buffer)
{
int64_t num_bytes;
const auto f_size = get_file_size(filename, num_bytes);
assert(f_size != -1);
buffer.resize(num_bytes);
const auto fd = open(filename, O_RDONLY, 0600);
assert(fd != -1);
struct stat fs;
const auto result = fstat(fd, &fs);
assert(result != -1);
int64_t num_bytes = fs.st_size;
buffer.resize(num_bytes);
int64_t read_bytes = 0;
auto r = 0;
do {
Expand Down