Fixing the CPU-Adam compile issue for the AMD architecture#796
Merged
RezaYazdaniAminabadi merged 2 commits intomasterfrom Feb 26, 2021
Merged
Fixing the CPU-Adam compile issue for the AMD architecture#796RezaYazdaniAminabadi merged 2 commits intomasterfrom
RezaYazdaniAminabadi merged 2 commits intomasterfrom
Conversation
RezaYazdaniAminabadi
requested review from
ShadenSmith,
arashashari,
awan-10,
cli99,
conglongli,
eltonzheng,
jeffra,
minjiaz,
niumanar,
samyam and
tjruwase
as code owners
jeffra
approved these changes
Feb 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems like adding empty string in the CPU-ADAM op_builder make gcc crash with this error: "gcc: error: : No such file or directory". I did a simple modification and returned -D__SCALAR__ instead of empty string. This won't make any difference in the cpp code since we already have conditions for both AVX2 and AVX512.
This fixes this issue.