[save_checkpoint] document the requirement to call for all ranks#801
Merged
tjruwase merged 1 commit intodeepspeedai:masterfrom Feb 26, 2021
Merged
[save_checkpoint] document the requirement to call for all ranks#801tjruwase merged 1 commit intodeepspeedai:masterfrom
tjruwase merged 1 commit intodeepspeedai:masterfrom
Conversation
stas00
requested review from
RezaYazdaniAminabadi,
ShadenSmith,
arashashari,
awan-10,
cli99,
conglongli,
eltonzheng,
jeffra,
minjiaz,
niumanar,
samyam and
tjruwase
as code owners
tjruwase
approved these changes
Feb 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As I was answered in #797 all processes must call this method - and I unknowingly called it for rank 0 and was getting a hanging. So this PR documents this requirement in the tutorial and the API doc.
Hmm, probably the
load_checkpointshould have a similar note too.Thank you.