Fixing gelu_checkpointing memory issue#812
Merged
RezaYazdaniAminabadi merged 3 commits intomasterfrom Mar 3, 2021
Merged
Conversation
RezaYazdaniAminabadi
requested review from
ShadenSmith,
arashashari,
awan-10,
cli99,
conglongli,
eltonzheng,
jeffra,
minjiaz,
niumanar,
samyam and
tjruwase
as code owners
|
Tested out the changes locally and are working fine. With my configuration which is analogous to Bert-Large memory savings are as follows
|
eltonzheng
approved these changes
Mar 3, 2021
sdtblck
added a commit
to EleutherAI/DeeperSpeed
that referenced
this pull request
Mar 4, 2021
* fixing buffers in transformer kernel when gelu-checkpoint is enabled * fixing the test issue for other memory optimization flags * fixing a bug for when attn_dropout_checkpoint is enabled Co-authored-by: Reza Yazdani <44502768+RezaYazdaniAminabadi@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR solves the memory error when enabling gelu-checkpoint. I also checked this modification for the rest of memory optimization flags inside transformer layer, and they all passed the unit tests.
@owmohamm, can you please verify if this is working on your side?
Thanks