fix TFLOPs calculation#350
Closed
polisettyvarma wants to merge 1 commit intodeepspeedai:mainfrom
polisettyvarma:main
Closed
fix TFLOPs calculation#350polisettyvarma wants to merge 1 commit intodeepspeedai:mainfrom polisettyvarma:main
polisettyvarma wants to merge 1 commit intodeepspeedai:mainfrom
polisettyvarma:main
Conversation
when GQA used, we observe right TFLOPs after this fix. huge difference in TFLOPs is solved for selective recompute when GQA is not used. some other minor difference will also be observed as logits macs also added.
polisettyvarma
requested review from
GuanhuaWang,
arashb,
awan-10,
conglongli,
duli2012,
eltonzheng,
mrwyattii,
tjruwase and
xiaoxiawu-microsoft
as code owners
Author
|
same PR in another PR - #371 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when GQA used, we observe right TFLOPs after this fix.
huge difference in TFLOPs is solved for selective recompute when GQA is not used.
some other minor difference will also be observed as logits macs also added.