Enable Megatron-LM workload on ROCm#68
Merged
tjruwase merged 4 commits intodeepspeedai:mainfrom Aug 12, 2022
Merged
Conversation
* Enable Megatron workload on ROCm
* Added ds_pretrain_gpt_350M_dense_pipeclean.sh
* removed a file
* Removed an extra line
* Fix to resolve the below rsqrtf() error on ROCm
/root/Megatron-DeepSpeed/megatron/fused_kernels/layer_norm_hip_kernel.hip:298:10: error: no matching function for call to 'rsqrtf'
return rsqrtf(v);
^~~~~~
/opt/rocm-5.2.0/llvm/lib/clang/14.0.0/include/__clang_hip_math.h:521:7: note: candidate function not viable: call to __device__ function from __host__ function
float rsqrtf(float __x) { return __ocml_rsqrt_f32(__x); }
^
rraminen
requested review from
RezaYazdaniAminabadi,
ShadenSmith,
arashb,
awan-10,
cli99,
conglongli,
duli2012,
eltonzheng,
jeffra,
minjiaz,
mrwyattii,
samyam,
tjruwase,
xiaoxiawu-microsoft and
yaozhewei
as code owners
rraminen
changed the title
Author
|
@jeffra, could you please review this PR? |
jithunnair-amd
approved these changes
Aug 2, 2022
tjruwase
reviewed
Aug 2, 2022
tjruwase
approved these changes
Aug 12, 2022
jeffra
approved these changes
Aug 12, 2022
saforem2
added a commit
to saforem2/Megatron-DeepSpeed
that referenced
this pull request
Nov 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the changes to