Skip to content

Python 3.11 support dropping 3.7#926

Merged
romi1502 merged 4 commits intodeezer:masterfrom
ValerioArnaudo:Add_support_py3.11_drop_py3.7
Jan 24, 2025
Merged

Python 3.11 support dropping 3.7#926
romi1502 merged 4 commits intodeezer:masterfrom
ValerioArnaudo:Add_support_py3.11_drop_py3.7

Conversation

@ValerioArnaudo
Copy link
Collaborator

@ValerioArnaudo ValerioArnaudo commented Jan 23, 2025

Pull request title

  • I read contributing guideline
  • I didn't find a similar pull request already open.
  • My PR is related to Spleeter only, not a derivative product (such as Webapplication, or GUI provided by others)

Description

This PR is meant to allow Spleeter to work with Python 3.11 (3.7 has been discountinued)

How this patch was tested

You tested it, right?
No new code has been added, just some refactoring in order for the unittest to pass for all supported python versions

  • I implemented unit test whicn ran successfully using poetry run pytest tests/
  • Code has been formatted using poetry run black spleeter
  • Imports has been formatted using `poetry run isort spleeter``

Documentation link and external references

Documentation regarding Str Enum backward compatibility

Copy link
Member

@romi1502 romi1502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@romi1502 romi1502 merged commit 9830c9b into deezer:master Jan 24, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants