Skip to content

Conversation

@joelmccoy
Copy link
Contributor

@joelmccoy joelmccoy commented Dec 11, 2025

Description

k8s-sidecar had releases for 1.30.10 and 1.30.11 yanked due to instability.

And there are multiple issues that prevent us from upgrade to 2.X.X (2.0.0 - 2.1.4) versions:

Updates the renovate config to skip these bad versions.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Steps to Validate

  • uds run (we hopefully shouldn't see flakiness in the loki ruler integration tests now)

Checklist before merging

Copilot AI review requested due to automatic review settings December 11, 2025 18:56
@joelmccoy joelmccoy requested a review from a team as a code owner December 11, 2025 18:56
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR downgrades the k8s-sidecar version from 1.30.10 (in Loki) and 2.1.4 (in Grafana) to 1.30.9 due to stability issues with the newer versions. Versions 1.30.10 and 1.30.11 were yanked by the upstream project, and version 2.X introduced significant memory usage increases and tmp directory mount issues that prevent upgrading beyond 1.30.9.

  • Downgrade k8s-sidecar from 1.30.10 to 1.30.9 in Loki components
  • Downgrade k8s-sidecar from 2.1.4 to 1.30.9 in Grafana components
  • Update repository path for Grafana's unicorn flavor to align with zarf.yaml configuration

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/loki/zarf.yaml Updates k8s-sidecar image references from 1.30.10 to 1.30.9 across all three flavors (upstream, registry1, unicorn)
src/loki/values/upstream-values.yaml Updates sidecar image tag from 1.30.10 to 1.30.9
src/loki/values/unicorn-values.yaml Updates sidecar image tag from 1.30.10 to 1.30.9
src/loki/values/registry1-values.yaml Updates sidecar image tag from 1.30.10 to 1.30.9
src/grafana/zarf.yaml Updates k8s-sidecar image references from 2.1.4 to 1.30.9 across all three flavors (upstream, registry1, unicorn)
src/grafana/values/upstream-values.yaml Updates sidecar image tag from 2.1.4 to 1.30.9
src/grafana/values/unicorn-values.yaml Updates sidecar image tag from 2.1.4 to 1.30.9 and corrects repository path from rfcurated/kiwigrid/k8s-sidecar to rfcurated/k8s-sidecar
src/grafana/values/registry1-values.yaml Updates sidecar image tag from 2.1.4 to 1.30.9

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

"quay.io/rfcurated/k8s-sidecar",
"ghcr.io/kiwigrid/k8s-sidecar"
],
"allowedVersions": "!/^(1\\.30\\.(1[0-9]|[2-9][0-9])|2\\.[01]\\.[0-4])/"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with this regex: https://regex101.com/r/Yj7Rp2/1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just remove the the leading !/ and trail / and replace // with / as these are escaped in the renovate config

@joelmccoy
Copy link
Contributor Author

It appears the registry1 image for 1.30.9 is having this issue:

2025-12-11T19:38:15.550398036Z stderr F {"time": "2025-12-11T19:38:15.550241+00:00", "level": "ERROR", "msg": "MaxRetryError when calling kubernetes: HTTPConnectionPool(host='localhost', port=80): Max retries exceeded with url: /api/v1/namespaces/grafana/configmaps?labelSelector=grafana_datasource&timeoutSeconds=60&watch=True (Caused by NewConnectionError(\"HTTPConnection(host='localhost', port=80): Failed to establish a new connection: [Errno 111] Connection refused\"))\n"}

Which points to this potentially this issue (which doesn't make sense since this should only exist in 1.30.10+). Need to further troubleshoot this.

@joelmccoy joelmccoy marked this pull request as draft December 11, 2025 20:24
@mjnagel mjnagel mentioned this pull request Dec 11, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants