-
Notifications
You must be signed in to change notification settings - Fork 31
fix: downgrade k8s-sidecar to 1.30.9 #2207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR downgrades the k8s-sidecar version from 1.30.10 (in Loki) and 2.1.4 (in Grafana) to 1.30.9 due to stability issues with the newer versions. Versions 1.30.10 and 1.30.11 were yanked by the upstream project, and version 2.X introduced significant memory usage increases and tmp directory mount issues that prevent upgrading beyond 1.30.9.
- Downgrade k8s-sidecar from 1.30.10 to 1.30.9 in Loki components
- Downgrade k8s-sidecar from 2.1.4 to 1.30.9 in Grafana components
- Update repository path for Grafana's unicorn flavor to align with zarf.yaml configuration
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/loki/zarf.yaml | Updates k8s-sidecar image references from 1.30.10 to 1.30.9 across all three flavors (upstream, registry1, unicorn) |
| src/loki/values/upstream-values.yaml | Updates sidecar image tag from 1.30.10 to 1.30.9 |
| src/loki/values/unicorn-values.yaml | Updates sidecar image tag from 1.30.10 to 1.30.9 |
| src/loki/values/registry1-values.yaml | Updates sidecar image tag from 1.30.10 to 1.30.9 |
| src/grafana/zarf.yaml | Updates k8s-sidecar image references from 2.1.4 to 1.30.9 across all three flavors (upstream, registry1, unicorn) |
| src/grafana/values/upstream-values.yaml | Updates sidecar image tag from 2.1.4 to 1.30.9 |
| src/grafana/values/unicorn-values.yaml | Updates sidecar image tag from 2.1.4 to 1.30.9 and corrects repository path from rfcurated/kiwigrid/k8s-sidecar to rfcurated/k8s-sidecar |
| src/grafana/values/registry1-values.yaml | Updates sidecar image tag from 2.1.4 to 1.30.9 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "quay.io/rfcurated/k8s-sidecar", | ||
| "ghcr.io/kiwigrid/k8s-sidecar" | ||
| ], | ||
| "allowedVersions": "!/^(1\\.30\\.(1[0-9]|[2-9][0-9])|2\\.[01]\\.[0-4])/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested with this regex: https://regex101.com/r/Yj7Rp2/1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just remove the the leading !/ and trail / and replace // with / as these are escaped in the renovate config
|
It appears the registry1 image for 1.30.9 is having this issue: Which points to this potentially this issue (which doesn't make sense since this should only exist in 1.30.10+). Need to further troubleshoot this. |
Description
k8s-sidecar had releases for 1.30.10 and 1.30.11 yanked due to instability.
And there are multiple issues that prevent us from upgrade to 2.X.X (2.0.0 - 2.1.4) versions:
Updates the renovate config to skip these bad versions.
Type of change
Steps to Validate
uds run(we hopefully shouldn't see flakiness in the loki ruler integration tests now)Checklist before merging