Skip to content

fix: check if exemption exists before cleanup #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rjferguson21 merged 2 commits into from
Jun 11, 2024
Merged

fix: check if exemption exists before cleanup #468

rjferguson21 merged 2 commits into from
Jun 11, 2024

Conversation

@rjferguson21
Copy link
Contributor

@rjferguson21 rjferguson21 commented Jun 7, 2024 •
edited
Loading

Description

Workaround for issue where Pepr store fails to update the store perpetually if a removeItem is called on a key that does not exist.

FIxes #463

Related Issue

Fixes #463

Relates to defenseunicorns/pepr#865

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@rjferguson21 rjferguson21 marked this pull request as ready for review June 7, 2024 23:00
@rjferguson21 rjferguson21 requested a review from a team as a code owner June 7, 2024 23:00
@rjferguson21 rjferguson21 requested a review from cmwylie19 June 8, 2024 13:11
mjnagel
mjnagel reviewed Jun 10, 2024
View reviewed changes
mjnagel
mjnagel previously approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@mjnagel mjnagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise, tested locally and seems to behave as expected.

@rjferguson21 rjferguson21 merged commit 735288b into main Jun 11, 2024
@rjferguson21 rjferguson21 deleted the policy-cleanup-fix branch June 11, 2024 15:05
@github-actions github-actions bot mentioned this pull request Jun 11, 2024
Merged
mjnagel pushed a commit that referenced this pull request Jun 13, 2024
@github-actions
chore(main): release 0.22.2 (#474)
84a408f 
🤖 I have created a release *beep* *boop*
---


##
[0.22.2](v0.22.1...v0.22.2)
(2024-06-13)


### Bug Fixes

* check if exemption exists before cleanup
([#468](#468))
([735288b](735288b))
* pepr operator derived netpol name collisions
([#480](#480))
([de60e25](de60e25))
* typo in comment
([#462](#462))
([582b1f4](582b1f4))


### Miscellaneous

* **deps:** update checkout to v4.1.7
([#478](#478))
([e91a0a3](e91a0a3))
* **deps:** update githubactions to v4.1.3
([#471](#471))
([2a9f44d](2a9f44d))
* **deps:** update uds to v0.11.1
([#472](#472))
([12fd798](12fd798))
* **deps:** update uds to v0.11.2
([#479](#479))
([f967f9a](f967f9a))
* **deps:** update velero to v1.30.2
([#476](#476))
([89bbda9](89bbda9))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
rjferguson21 added a commit that referenced this pull request Jul 11, 2024
@rjferguson21
fix: check if exemption exists before cleanup (#468)
f62bf50 
## Description
Workaround for issue where Pepr store fails to update the store
perpetually if a `removeItem` is called on a key that does not exist.

FIxes #463

## Related Issue
Fixes #463
<!-- or -->
Relates to defenseunicorns/pepr#865

## Type of change

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)

## Checklist before merging

- [ ] Test, docs, adr added or updated as needed
- [ ] [Contributor Guide
Steps](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md)(https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md#submitting-a-pull-request)
followed
rjferguson21 pushed a commit that referenced this pull request Jul 11, 2024
@github-actions
chore(main): release 0.22.2 (#474)
2a5c985 
🤖 I have created a release *beep* *boop*
---


##
[0.22.2](v0.22.1...v0.22.2)
(2024-06-13)


### Bug Fixes

* check if exemption exists before cleanup
([#468](#468))
([735288b](735288b))
* pepr operator derived netpol name collisions
([#480](#480))
([de60e25](de60e25))
* typo in comment
([#462](#462))
([582b1f4](582b1f4))


### Miscellaneous

* **deps:** update checkout to v4.1.7
([#478](#478))
([e91a0a3](e91a0a3))
* **deps:** update githubactions to v4.1.3
([#471](#471))
([2a9f44d](2a9f44d))
* **deps:** update uds to v0.11.1
([#472](#472))
([12fd798](12fd798))
* **deps:** update uds to v0.11.2
([#479](#479))
([f967f9a](f967f9a))
* **deps:** update velero to v1.30.2
([#476](#476))
([89bbda9](89bbda9))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
mjnagel pushed a commit to BagelLab/uds-core that referenced this pull request Nov 14, 2025
@rjferguson21 @mjnagel
fix: check if exemption exists before cleanup (defenseunicorns#468)
7071b90 
## Description
Workaround for issue where Pepr store fails to update the store
perpetually if a `removeItem` is called on a key that does not exist.

FIxes defenseunicorns#463

## Related Issue
Fixes defenseunicorns#463
<!-- or -->
Relates to defenseunicorns/pepr#865

## Type of change

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)

## Checklist before merging

- [ ] Test, docs, adr added or updated as needed
- [ ] [Contributor Guide
Steps](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md)(https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md#submitting-a-pull-request)
followed
mjnagel pushed a commit to BagelLab/uds-core that referenced this pull request Nov 14, 2025
@github-actions @mjnagel
chore(main): release 0.22.2 (defenseunicorns#474)
e9bf1fb 
🤖 I have created a release *beep* *boop*
---


##
[0.22.2](defenseunicorns/uds-core@v0.22.1...v0.22.2)
(2024-06-13)


### Bug Fixes

* check if exemption exists before cleanup
([defenseunicorns#468](defenseunicorns#468))
([735288b](defenseunicorns@735288b))
* pepr operator derived netpol name collisions
([defenseunicorns#480](defenseunicorns#480))
([de60e25](defenseunicorns@de60e25))
* typo in comment
([defenseunicorns#462](defenseunicorns#462))
([582b1f4](defenseunicorns@582b1f4))


### Miscellaneous

* **deps:** update checkout to v4.1.7
([defenseunicorns#478](defenseunicorns#478))
([e91a0a3](defenseunicorns@e91a0a3))
* **deps:** update githubactions to v4.1.3
([defenseunicorns#471](defenseunicorns#471))
([2a9f44d](defenseunicorns@2a9f44d))
* **deps:** update uds to v0.11.1
([defenseunicorns#472](defenseunicorns#472))
([12fd798](defenseunicorns@12fd798))
* **deps:** update uds to v0.11.2
([defenseunicorns#479](defenseunicorns#479))
([f967f9a](defenseunicorns@f967f9a))
* **deps:** update velero to v1.30.2
([defenseunicorns#476](defenseunicorns#476))
([89bbda9](defenseunicorns@89bbda9))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjnagel mjnagel mjnagel approved these changes

@cmwylie19 cmwylie19 Awaiting requested review from cmwylie19

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

RemoveItem is too fast for store - policies.Store.removeItem(p);

3 participants

@rjferguson21 @mjnagel